search

jhillyerd / plugin-git

Git aliases plugin for the Fish shell (similar to oh-my-zsh git)
MIT License
607 stars 85 forks source link

Abbreviations do not work after restart with fish 3.6.0 #90

Closed niklasnatter closed 1 year ago

niklasnatter commented 1 year ago

Hey, first of all - thanks a lot working on this plugin. I switched to fish from oh-my-zsh a few months ago and this plugin was a lifesaver!

I just set up a new machine today and installed the plugin with fisher:

fisher install jhillyerd/plugin-git

Unfortunately, it looks like the abbreviations of the plugin do not work anymore after i restart my machine. I reinstalled the plugin, but this only solved the problem until the next restart.

I suspect that this is related to the changes to abbr that come with fish 3.6.0. Is there a trick/workaround to make the plugin compatible with fish 3.6.0?

Thanks a lot in advance!

niklasnatter commented 1 year ago

I just found a potential workaround in https://github.com/jorgebucaran/fisher/issues/755#issuecomment-1408547461. Adding the following lines to my ~/.config/fish/config.fish fixed the problem in a first test:

# https://github.com/jhillyerd/plugin-git/issues/90
set -e __git_plugin_initialized
__git.init
jhillyerd commented 1 year ago

Yes, that looks like a good workaround. #88 was a first look at fixing this, but appears to have stalled. I'll take a deeper look, probably this week.

lecovi commented 1 year ago

Yes! It worked for me too.