jhipster / generator-jhipster-docker-compose

DO NOT USE THIS REPO - it's now a sub-generator in the main generator-jhipster project
Other
12 stars 7 forks source link

generator can not distinguish between maven or gradle based applications #10

Closed xetys closed 8 years ago

xetys commented 8 years ago

when any application in the subdirectories was built by gradle rather then with maven, the generator fails to find the correct docker directory

deepu105 commented 8 years ago

Yes there is no gradle support yet On 17 Mar 2016 06:39, "David Steiman" notifications@github.com wrote:

when any application in the subdirectories was built by gradle rather then with maven, the generator fails to find the correct docker directory

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/jhipster/generator-jhipster-docker-compose/issues/10

jdubois commented 8 years ago

Well, there's a Gradle plugin to build a Docker image, but I don't know how it works :-( Le 17 mars 2016 2:10 AM, "Deepu K Sasidharan" notifications@github.com a écrit :

Yes there is no gradle support yet On 17 Mar 2016 06:39, "David Steiman" notifications@github.com wrote:

when any application in the subdirectories was built by gradle rather then with maven, the generator fails to find the correct docker directory

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub <https://github.com/jhipster/generator-jhipster-docker-compose/issues/10

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/jhipster/generator-jhipster-docker-compose/issues/10#issuecomment-197632994

xetys commented 8 years ago

Oh, so far I tested yesterday night the docker plugin works like a charm. For some tests I just copied the docker folder from build to target, which worked for the generator to work through

PierreBesson commented 8 years ago

@xetys I will add docker gradle support to the main generator. [EDIT] PR done: https://github.com/jhipster/generator-jhipster/pull/3195

jdubois commented 8 years ago

@xetys can you tell me how you used it? I'm currently writing the documentation for v3 and it looks like you know it better than me!

deepu105 commented 8 years ago

I think main generator already supports docker build. we just need to add support in this generator

Thanks & Regards, Deepu

On Thu, Mar 17, 2016 at 5:51 PM, Julien Dubois notifications@github.com wrote:

@xetys https://github.com/xetys can you tell me how you used it? I'm currently writing the documentation for v3 and it looks like you know it better than me!

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/jhipster/generator-jhipster-docker-compose/issues/10#issuecomment-197794304

xetys commented 8 years ago

yes, it already was working as i checked out yesterday evening. The command was "gradle buildDocker" or "gradle bootRepackage buildDocker", which is an equivalent to "mvn package docker:build"...it generates the same files, but in /build, not in /target

P.S. @jdubois i've updated my github profile data, so you are able to contact me

deepu105 commented 8 years ago

Ok so for us it should be gradle bootRepackage buildDocker

Thanks & Regards, Deepu

On Thu, Mar 17, 2016 at 8:48 PM, David Steiman notifications@github.com wrote:

yes, it already was working as i checked out yesterday evening. The command was "gradle buildDocker" or "gradle bootRepackage buildDocker", which is an equivalent to "mvn package docker:build"...it generates the same files, but in /build, not in /target

P.S. @jdubois https://github.com/jdubois i've updated my github profile data, so you are able to contact me

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/jhipster/generator-jhipster-docker-compose/issues/10#issuecomment-197863062

PierreBesson commented 8 years ago

@xetys, thanks for pointing it out that the buildDocker task already existed @jdubois and I were mistaken.

jdubois commented 8 years ago

OK thanks I'll try it

pascalgrimaud commented 8 years ago

See my PR : https://github.com/jhipster/generator-jhipster/pull/3029 Maven and Gradle are supported both! I followed the official guide : https://spring.io/guides/gs/spring-boot-docker/