search

jhipster / generator-jhipster-ionic

Ionic for JHipster ✨
https://developer.okta.com/blog/2022/05/12/ionic-angular-jhipster
Apache License 2.0
191 stars 49 forks source link

CI failing: Cannot read properties of undefined (reading 'name') #607

Closed mraible closed 2 years ago

mraible commented 2 years ago

Not sure why the upgrade to Node 16 and JHipster 7.5 is failing. Here's the error:

Error jhipster-ionic:import-jdl /home/runner/backend/monolith-jwt.jdl --force 

Cannot read properties of undefined (reading 'name')
Error: Process completed with exit code 1.

Creating this issue to attach a bug bounty and get some help.

mraible commented 2 years ago

@mshima Do you know what might be causing import JDL to fail? I tried to debug to get some additional information, but was unable to.

mshima commented 2 years ago

I will take a look.

Later today or tomorrow

mshima commented 2 years ago

@mraible https://github.com/yeoman/environment/commit/66752e4b07a6da5eb93b9ae53ad66aacd025c2a8 should fix this problem. Just updating yeoman-environment should fix this issue.

mraible commented 2 years ago

@mshima It looks like your PR already has the update for yeoman-environment v3.9.1. https://github.com/jhipster/generator-jhipster-ionic/pull/611/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R47

Is there something else that needs to be done?

mshima commented 2 years ago

No, my PR drops yo. If you prefer to keep it, updating the environment should be enough.

mraible commented 2 years ago

No, my PR drops yo.

I think that's OK. This doesn't change the need to run yo ionic-jhipster does it? The ionic4j CLI I created as part of this project doesn't work.

mshima commented 2 years ago

I think that's OK. This doesn't change the need to run yo ionic-jhipster does it? The ionic4j CLI I created as part of this project doesn't work.

Actually I didn’t try yo, but should work. I prefer to drop yo support. Yo can be slow and I think yo-doctor unnecessary and problematic. That’s why I reimplemented the cli and dropped yo from the documentation.

Blueprint reimplementation is almost done. Have you managed to make protractor succeed with angular 13?

mraible commented 2 years ago

I haven't tried protractor with Angular 13. I won't know until https://github.com/ionic-team/starters/pull/1716 is merged. If it doesn't work, I can reimplement e2e tests with Cypress.