search

jhipster / generator-jhipster-nodejs

A NodeJS blueprint that creates the backend using NestJS
https://www.npmjs.com/package/generator-jhipster-nodejs
Apache License 2.0
256 stars 79 forks source link

Update to latest node (lts) and package versions. #278

Closed pahlers closed 2 years ago

pahlers commented 2 years ago

Is your feature request related to a problem? Please describe.

It would be good to update nodejs and the packages to the latest version. Current npm audit shows 31 vulnerabilities (12 moderate, 13 high, 6 critical). That's a bad sign.

Describe the solution you'd like Update nodejs to v16 (and support v18) and update all packages to the latest version.

I started with it and replaced a lot of require with import (eazy). But now I'm stuck because I don't understand the inner working of the application. It can't load cli/commands, because there isn't one in the project. But how does that work in the current version ???.

Describe alternatives you've considered Sorry to say, but remove the support of nodejs from jHipster. This isn't safe.

pahlers commented 2 years ago

Forgot to say. Excellent project and code. :+1:

ghost commented 2 years ago

Hi @pahlers, thanks for the interest. However, I don't understand your issue. A command line file is added in cli folder, and a PR to upgrade blueprint is in review (https://github.com/jhipster/generator-jhipster-nodejs/pull/274)

But, there are some errors to resolve on github actions, so the upgrade is not so mandatory for now.

pahlers commented 2 years ago

I'm confused too. I don't see any commands.js in de cli folder. See the screenshot. Am I linking the generator-jhipster project incorrect?

image

Nice to see there is already a update. Is there a way I can help?

ghost commented 2 years ago

The screenshoot is correct. nhipster.js is the command line file (declared in bin section of package.json). From the new jhipster blueprint 7.x is been done a naming convention for the cli file as you say (commands file name), before of that everyone created a personal command file (I chose nhipster.js because is the name of project, and you run nhipster command as blueprint).

You can try to resolve github action error, caused by node.js lastvversion automatically used in action, even if in the yml file is declared a fixed version.

pahlers commented 2 years ago

I will give it a go. I have no experience with Github. More with Jenkins and Gitlab. But how hard can it be! (Famous last words)