search

jhipster / generator-jhipster

JHipster is a development platform to quickly generate, develop, & deploy modern web applications & microservice architectures.
https://www.jhipster.tech
Apache License 2.0
21.57k stars 4.02k forks source link

Update react dependencies with major version changes #11651

Closed deepu105 closed 4 years ago

deepu105 commented 4 years ago

Update the following dependencies in React implementation. It could be bit of work since we haven't updated these in a while

 react-toastify          4.5.2  →  5.5.0 
 react-transition-group  2.7.0  →  4.3.0 
 reactstrap              7.1.0  →  8.4.1 
 uuid                    3.3.3  →  7.0.3 
 html-webpack-plugin     3.2.0  →  4.2.0
MathieuAA commented 4 years ago

@deepu105 if you're not already doing it I'm willing to give it a go, I have the same use case in one of my apps :)

mraible commented 4 years ago

I created a similar issue for Angular.

deepu105 commented 4 years ago

@MathieuAA plz go ahead, I just did #11653 but the dependencies here needs bit more work. AFAIK react-toastify, react-transition-group and html-webpack-plugin has breaking changes. I suggest you branch off from #11653 since it has everything else uptodate

MathieuAA commented 4 years ago

@deepu105 alright then

MathieuAA commented 4 years ago

First issue I've encountered, with the html-webpack-plugin dependency.

TypeError: Cannot read property 'tapAsync' of undefined
    at /home/mathieu/projects/munchy/node_modules/base-href-webpack-plugin/build/index.js:28:65
    ...

Found this issue in the repo that seems to correspond: https://github.com/jantimon/html-webpack-plugin/issues/1377#issuecomment-605678041 The base-href-webpack-plugin dependency didn't receive updates since early 2019. I'm gonna focus on the others 4 that seem to be easier to deal with. I'll go back to this dependency after the others.

deepu105 commented 4 years ago

I think this one is not very important anyway

On Mon, 27 Apr 2020, 8:54 pm Mathieu ABOU-AICHI, notifications@github.com wrote:

First issue I've encountered, with the html-webpack-plugin dependency.

TypeError: Cannot read property 'tapAsync' of undefined at /home/mathieu/projects/munchy/node_modules/base-href-webpack-plugin/build/index.js:28:65 ...

Found this issue in the repo that seems to correspond: jantimon/html-webpack-plugin#1377 (comment) https://github.com/jantimon/html-webpack-plugin/issues/1377#issuecomment-605678041 The base-href-webpack-plugin dependency didn't receive updates since early 2019. I'm gonna focus on the others 4 that seem to be easier to deal with. I'll go back to this dependency after the others.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jhipster/generator-jhipster/issues/11651#issuecomment-620168735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIOKF2W2FL2EUHW7Q5A773ROXIFNANCNFSM4MSCFLHA .

MathieuAA commented 4 years ago

So far, except the last dependency, everything's okay. There's just reactstrap, but it's very minor: https://github.com/reactstrap/reactstrap/blob/master/CHANGELOG.md#breaking-changes. I'm doing some more tests in real apps but I think you can include them in your PR

MathieuAA commented 4 years ago

BTW, I didn't see any use of the uuid package in the front-end code (except in the package.json file). Unless I'm missing something...

deepu105 commented 4 years ago

Probably its from some legacy stuff or used only in some specific option combination

On Tue, 28 Apr 2020, 12:43 am Mathieu ABOU-AICHI, notifications@github.com wrote:

BTW, I didn't see any use of the uuid package in the front-end code (except in the package.json file). Unless I'm missing something...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jhipster/generator-jhipster/issues/11651#issuecomment-620273806, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIOKF3IFVXO33KJGKYS4XTROYDA5ANCNFSM4MSCFLHA .

MathieuAA commented 4 years ago

Claimed my half: https://opencollective.com/generator-jhipster/expenses/17196. Thanks again Deepu!