jhipster / generator-jhipster

JHipster is a development platform to quickly generate, develop, & deploy modern web applications & microservice architectures.
https://www.jhipster.tech
Apache License 2.0
21.54k stars 4.02k forks source link

Add support for simple JDL deployments #12511

Closed PierreBesson closed 1 year ago

PierreBesson commented 4 years ago
Overview of the feature request

Since the JDL supports the deployment keyword, it would be nice to have it support simple use cases. Currently, JHipster crashes when attempting to generate deployment for a single app using JDL.

Motivation for or Use Case

I want the following JDL file :

application {
  config {
    baseName testApplication
    prodDatabaseType postgresql
  }
}

deployment {
  deploymentType kubernetes
  dockerRepositoryName "pbesson"
}

To generate a valid JHipster application and its Kubernetes deployment files in deploy/kubernetes.

It should work similarly for other deployment sub-generators. And for the docker-compose option, we should deprecate the src/main/docker/app.yml file which is a duplicate of this feature.

deepu105 commented 4 years ago

Do you mean it crashes for monoliths? The deployment spec works for Microservices (at least used to work when I coded it)

pascalgrimaud commented 4 years ago

We need to check if the 'app.yml' is used or not by the docker compose sub generator.

If not, we should just remove it... it was created long time ago, before the sub gen docker compose, I'm not sure it is really used by our users today

mraible commented 4 years ago

Last time I tried, Docker Compose worked for app.yml. If we remove it, how can we start everything via Docker?

pascalgrimaud commented 4 years ago

@mraible : IMO, the best is to use docker-compose sub generator. It's here for that.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 30 days with no activity. Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted. We are accepting PRs :smiley:. Comment or this will be closed in 7 days