jhipster / generator-jhipster

JHipster is a development platform to quickly generate, develop, & deploy modern web applications & microservice architectures.
https://www.jhipster.tech
Apache License 2.0
21.54k stars 4.02k forks source link

Move the logic of converting criteria to specification out of QueryService. #13133

Closed yelhouti closed 2 years ago

yelhouti commented 3 years ago
Overview of the feature request

In the current generator, it is the Job of the EntityQueryService to convert the criteria into a specification, the problem with this approach is that it prevents from easily filtering relationships based on these fields if the entity is not marked as filterable. Also all the logic of the of createSpecification is static and should not require retrieving a service and allocating resources for it. IMO, teck.jhipster.queryService that has all buildSpecification methods be deprecated in favor of a helper class called SpecificationHelper with all public static methods.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 30 days with no activity. Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted. We are accepting PRs :smiley:. Comment or this will be closed in 7 days