search

jhipster / generator-jhipster

JHipster is a development platform to quickly generate, develop, & deploy modern web applications & microservice architectures.
https://www.jhipster.tech
Apache License 2.0
21.51k stars 4.02k forks source link

Move the blueprint generator to the JHipster 7 architecture #14135

Closed avdev4j closed 3 years ago

avdev4j commented 3 years ago

The JHipster 7 release is about to come. We need to upgrade this generator to match the breaking changes introduced in this new major version.

I have created a v7 branch: https://github.com/jhipster/generator-jhipster-blueprint/tree/jhipster-7

here is what I'm thinking about:

Feel free to add anything you think it's mandatory for the v7 release.

pascalgrimaud commented 3 years ago

Can you add a new item to your list plz @avdev4j ?

avdev4j commented 3 years ago

@pascalgrimaud Done!

I have also opened a PR for fixing some parts of the documentation. We can merge it now while we need to wait for the other one (related to the v7).

please find this PR here: https://github.com/jhipster/jhipster.github.io/pull/1087

mshima commented 3 years ago

Why don't we integrate generator-jhipster-blueprint into generator-jhipster?

avdev4j commented 3 years ago

@mshima I'm 100% in favor of that. Btw, this generator is not maintained enough, maybe it could help.

If we do that, we need to do it for modules also.

murdos commented 3 years ago

Why don't we integrate generator-jhipster-blueprint into generator-jhipster?

* No need to install `yo` which is somewhat unmaintained.

* Easy as jhipster create-blueprint.

The only downside I see is that the jhipster cli is mainly used to work inside a project generated with jhipster. Whereas here the use case is a bit different: you want to customize the jhipster generator by generating a blueprint. So different context, and also different target user (generator developer vs generator user).

avdev4j commented 3 years ago

after all, I'm not sure it could be a good idea because of what you said @murdos not sure it will help to maintain it better...

mshima commented 3 years ago

I really don't see benefits on having to install yo if jhipster will be installed for both blueprint developer and generator user. It will improve integration:

IMO it's @murdos call as maintainer and stream leader here.

avdev4j commented 3 years ago

Let's open a new ticket for the proposal, maybe more ideas can help to make a decision.

I see pro and cons in both possibilities.

Btw the PR is ready for review so if anybody from @jhipster/developers wants to review it, feel free; so can merge it after that and move to modules ;).

deepu105 commented 3 years ago

Lets first upgrade the generator-jhipster-blueprint to work with v7 and we can discuss separately in another ticket about merging it into main generator

murdos commented 3 years ago

Lets first upgrade the generator-jhipster-blueprint to work with v7 and we can discuss separately in another ticket about merging it into main generator

👍

pascalgrimaud commented 3 years ago

@mshima : following https://github.com/jhipster/generator-jhipster/pull/14193 do you think we need to upgrade the blueprint generator ?

mshima commented 3 years ago

@pascalgrimaud no.

avdev4j commented 3 years ago

So there is something else to do here?

avdev4j commented 3 years ago

I'm closing this one since the job has been done ;)

avdev4j commented 3 years ago

bounty claimed here https://opencollective.com/generator-jhipster/expenses/36160

pascalgrimaud commented 3 years ago

@avdev4j : approved