Closed marklcg closed 1 month ago
This issue is stale because it has been open 30 days with no activity. Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted. We are accepting PRs :smiley:. Comment or this will be closed in 7 days
@pascalgrimaud I have the same issue, please reopen.
See my sample app.
This issue is stale because it has been open 30 days with no activity. Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted. We are accepting PRs :smiley:. Comment or this will be closed in 7 days
Keep it open please.
This issue is stale because it has been open 30 days with no activity. Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted. We are accepting PRs :smiley:. Comment or this will be closed in 7 days
The issue also persists in 7.4.0.
This issue is stale because it has been open 30 days with no activity. Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted. We are accepting PRs :smiley:. Comment or this will be closed in 7 days
I still don't get the thing about this 'incremental changelog' feature, when we have the liquibase-maven-plugin that is maintained by the liquibase community thus bullet proof... I would have preferred to get a 'smart' integration of it within the jdl generation process (and of course also integrated with the reactive framework, which is not the case today).
Usage of the liquibase-maven-plugin:
./mvnw liquibase:diff
command to get your new changelogI think that we could wrap this workflow into a import-jdl --incremental-changelog-from-branch=<legacy branch>
which would:
./mvnw compile
./mvnw liquibase:diff
I know that it would be a little bit painful to implement, but we won't have to maintain our changelog's code anymore (or maybe just the part that updates the .jhipster/*.json
in order to keep sources changelog timestamps file and will easily keep being bullet proof on the generated code side.
@Tcharl Should we leave this issue open?
@mraible yes please leave it open.
I have been debugging this today and the issue seems to come from:
When an entity is added by specifying only and exactly one side:
relationship ManyToOne {
A{b required} to B
}
NOT
relationship ManyToOne {
A to B
}
or
relationship ManyToOne {
A{b required} to B{a}
}
it causes jhipster to not see that B has a new relationship, and not calling prepareFakeData on it, which causes the csv (and depending on the version other stuff) to be broken.
EDIT: workaround:
generate first with the 2 sides, then regenerate after removing a side if you don't want it
This issue is stale because it has been open for too long without any activity. Due to the moving nature of jhipster generated application, bugs can become invalid. If this issue still applies please comment otherwise it will be closed in 7 days
Overview of the issue
I have an existing project with multiple entities and incremental changelogs enabled. I'm attempting to add a new entity with unidirectional ManyToOne relationships to the existing entities, however, the generator is not filling in the "type" attribute for the column definition correctly. It is empty resulting in liquibase errors later. In the example case, the type value should be "bigint" but is instead empty ("").
Motivation for or Use Case
I would like to add new entities and with unidirectional relationships to an existing project.
Reproduce the error
This project was generated with jhipster using:
It's a monolith with default selections and mariadb. I created two entities by importing the following test.jdl (found in the project root).
To reproduce the issue, add the following to the JDL:
Then re-import:
You will see that the column type is null:
Related issues
N/A
Suggest a Fix
I currently manually set the column types after the import to work around the issue.
JHipster configuration
INFO! Using JHipster version installed locally in current project's node_modules Welcome to the JHipster Information Sub-Generator
JHipster Version(s)
JHipster configuration, a
.yo-rc.json
file generated in the root folder.yo-rc.json file
JDL for the Entity configuration(s)
entityName.json
files generated in the.jhipster
directoryJDL entity definitions
Environment and Tools
openjdk version "11.0.11" 2021-04-20 OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.10) OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.10, mixed mode, sharing)
git version 2.27.0 node: v12.18.2 npm: 7.13.0
Docker version 20.10.2, build 20.10.2-0ubuntu1~20.10.1
docker-compose version 1.25.0, build unknown
No change to package.json was detected. No package manager install will be executed. Congratulations, JHipster execution is complete!
Entity configuration(s)
entityName.json
files generated in the.jhipster
directorySee attached.
Browsers and Operating System
Linux pop-os 5.11.0-7614-generic #15~1618626693~20.10~ecb25cd-Ubuntu SMP Thu Apr 22 16:00:45 UTC x86_64 x86_64 x86_64 GNU/Linux