jhipster / generator-jhipster

JHipster is a development platform to quickly generate, develop, & deploy modern web applications & microservice architectures.
https://www.jhipster.tech
Apache License 2.0
21.54k stars 4.02k forks source link

JHipster Configuration Hazelcast #17103

Closed Mixermachine closed 10 months ago

Mixermachine commented 2 years ago
Overview of the issue

Hy JHipster-Team,

I'm currently migrating an application to JHipster 7.4 and I found some things that look odd to me. The JHipster documentation still references io.github.jhipster.config.JHipsterProperties in https://www.jhipster.tech/common-application-properties/. Shouldn't that be tech.jhipster.config.JHipsterProperties ?

It also mentions jhipster.cache.hazelcast.management-center. Is this still a valid variable? I get errors when I try to set that variable.

Property: jhipster.cache.hazelcast.management-center.enabled
    Value: true
    Origin: class path resource [config/application.yml] - 197:26
    Reason: The elements [jhipster.cache.hazelcast.management-center.enabled,jhipster.cache.hazelcast.management-center.update-interval,jhipster.cache.hazelcast.management-center.url] were left unbound.
    Property: jhipster.cache.hazelcast.management-center.update-interval
    Value: 5

Has the management-center setting been migrated to some different point?

Motivation for or Use Case

Helping new developers.

Reproduce the error

https://www.jhipster.tech/common-application-properties/#2

Related issues

Suggest a Fix
  1. Reference current version JHipsterProperties.class
  2. Suggest an alternative location for the management-center configs.
JHipster Version(s)

JHipster 7.4

JHipster configuration

Documentation issue.

Entity configuration(s) entityName.json files generated in the .jhipster directory

Documentation issue.

Browsers and Operating System

Chrome 96, Edge 96

Greetings from Munich

pascalgrimaud commented 2 years ago

The class comes from here: https://github.com/jhipster/jhipster-bom/blob/main/jhipster-framework/src/main/java/tech/jhipster/config/JHipsterProperties.java

Edit: the property is not here any more

About our documentation, it is not correct, the package has changed

Mixermachine commented 2 years ago

@pascalgrimaud Yes that is why I created the issue :) I just wanted to notify you as this might hinder new developers.

Do you know where the setting for the hazelcast management-center has gone? I need to migrate my application to the new jhipster version and have to configure the management-center properties.

pascalgrimaud commented 2 years ago

Looking at the history: https://github.com/jhipster/jhipster-bom/commits/main/jhipster-framework/src/main/java/tech/jhipster/config/JHipsterProperties.java

There is this PR and commit:

With this comment in code:

            /**
             * In the Hazelcast v4.x, the cluster node doesn't expose
             * configurations to connect to the management center. Setting up
             * of this class properties don't provide any behavior and has
             * been retained for the backward compatibility, and should be
             * removed in the next major release of the JHipster
             */

Hope it will help you.

Mixermachine commented 2 years ago

Oh ok We still use Hazelcast 3.11.

Seems like I need to manually configure the Hazelcast node somehow

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Our core developers tend to be more verbose on denying. If there is no negative comment, possibly this feature will be accepted. We are accepting PRs :smiley:. Comment or this will be closed in 7 days

github-actions[bot] commented 11 months ago

This issue is stale because it has been open for too long without any activity. Due to the moving nature of jhipster generated application, bugs can become invalid. If this issue still applies please comment otherwise it will be closed in 7 days