jhipster / generator-jhipster

JHipster is a development platform to quickly generate, develop, & deploy modern web applications & microservice architectures.
https://www.jhipster.tech
Apache License 2.0
21.54k stars 4.02k forks source link

SwaggerUI via Manual Distribution #18407

Closed olgunkaya closed 9 months ago

olgunkaya commented 2 years ago

Today, I spent considerable amount of time to figure out what's going on with swagger UI and realized that jhipster only includes mvc artifact with the swagger-ui web distro in webapps.

Is there any specific reason to not to go with (link)

   <dependency>
      <groupId>org.springdoc</groupId>
      <artifactId>springdoc-openapi-ui</artifactId>
      <version>x.y.z</version>
   </dependency>

but instead go with mvc configurer [ in this link ](https://springdoc.org/#spring-webmvc-support ?

 <dependency>
      <groupId>org.springdoc</groupId>
      <artifactId>springdoc-openapi-webmvc-core</artifactId>
      <version>x.y.z</version>
   </dependency>

I added the above mentioned ui with proper version (in my case 1.6.6) and now it works, displayes the UI. But not sure if I do this correct/properly.

mshima commented 2 years ago

We provide swagger at the client side. Our swagger config is microservice aware. Springdoc provided one is not. The springdoc swagger ui makes sense to monolith with skipClient only.

There is a closed bug about this solution. Don't know if we have documentation about this, we could add.

olgunkaya commented 2 years ago

I think, I hit the condition, skipClient and monolith :)

Teşekkürler Olgun Kaya

Marcelo Shima @.***> şunları yazdı (19 Nis 2022 17:42):

 We provide swagger at the client side. Our swagger config is microservice aware. Springdoc provided one is not. The springdoc swagger ui makes sense to monolith with skipClient only.

There is a closed bug about this solution. Don't know if we have documentation about this, we could add.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

github-actions[bot] commented 10 months ago

This issue is stale because it has been open for too long without any activity. Due to the moving nature of jhipster generated application, bugs can become invalid. If this issue still applies please comment otherwise it will be closed in 7 days