search

jhipster / generator-jhipster

JHipster is a development platform to quickly generate, develop, & deploy modern web applications & microservice architectures.
https://www.jhipster.tech
Apache License 2.0
21.55k stars 4.03k forks source link

Use dasherizedBaseName at docker files. #19160

Open mayconfrr opened 2 years ago

mayconfrr commented 2 years ago
Overview of the feature request

Allow dash (-) on base name for application

Motivation for or Use Case

Not only is it best practice on docker image naming or project naming, the current regex with underline (_) enforces bad naming practice if you want to separate words.

Suggested change

Current is /^[A-Za-z][A-Za-z0-9]*$/ Change JDL regex for application.config.baseName to /^[A-Za-z][A-Za-z0-9-]*$/

atomfrede commented 2 years ago

I think this once was done for a reason (I think the package name was initially the same as the base same), but I think we have changed this, so we might change the base name property to allow dashes (which I also noticed and wondered why).

github-actions[bot] commented 9 months ago

This issue is stale because it has been open for too long without any activity. Due to the moving nature of jhipster generated application, bugs can become invalid. If this issue still applies please comment otherwise it will be closed in 7 days

mshima commented 9 months ago

We should use dasherizedBaseName image name at docker compose files. It's lots of places to change, tagging as v9.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for too long without any activity. Due to the moving nature of jhipster generated application, bugs can become invalid. If this issue still applies please comment otherwise it will be closed in 7 days