jhipster / generator-jhipster

JHipster is a development platform to quickly generate, develop, & deploy modern web applications & microservice architectures.
https://www.jhipster.tech
Apache License 2.0
21.54k stars 4.02k forks source link

JHipster does not recognize Node.js 18 as LTS #20349

Closed vdespa closed 9 months ago

vdespa commented 1 year ago
Overview of the issue

JHipster issues the following warning when used with Node.js 18: "WARNING! Your Node version is not LTS (Long Term Support), use it at your own risk! JHipster does not support non-LTS releases, so if you encounter a bug, please use a LTS version first."

image
Motivation for or Use Case
Reproduce the error

Run jhipster

Related issues
Suggest a Fix
JHipster Version(s)

JHipster v7.9.3

JHipster configuration
Entity configuration(s) entityName.json files generated in the .jhipster directory
Browsers and Operating System

macOS

mraible commented 1 year ago

Yes, we should fix this. I'll add a bug bounty.

mshima commented 1 year ago

@DanielFran assigned to you. 😄 WARNING! Your Node version is not LTS (Long Term Support), use it at your own risk! JHipster does not support non-LTS releases, so if you encounter a bug, please use a LTS version first. The error message seems the node is 18 prior to LTS version. The warning didn't show at MacOS M1 + node 18.12.1

The logic looks ok: https://github.com/jhipster/generator-jhipster/blob/bb188e00ca686d506658737ed7f91c478a7afcce/generators/base/generator-base-private.mjs#L511-L515

Just need a new release.

mraible commented 1 year ago

Are we sure JHipster v7 works with Node 18? This issue suggests it does not.

antarus commented 1 year ago

with 18, I don't get the same error when I run it.

image

work with 16.

windows 10 with wsl2

mshima commented 1 year ago

Following https://github.com/jhipster/generator-jhipster/pull/20394:

Generation works and as long as ./npmw is used instead of the system node/npm, the application will work fine.

vdespa commented 1 year ago

with 18, I don't get the same error when I run it.

That is issue #19627

dagboujhatem commented 1 year ago

With the node V18.15.2 I don't get the same error when I run it. OS: macOS

ljoboy commented 1 year ago

With node v18.16.0 same error OS: Linux Mint

BrayanMnz commented 1 year ago

Are you working on this @DanielFran ?

BrayanMnz commented 1 year ago

Seems like just a release was needed and this is not an issue anymore. maybe this can be closed.

deepu105 commented 1 year ago

closing as release v7.9.4 is being done

vishal423 commented 1 year ago

Blueprints still doesn't work with nodejs v18 due to incorrect module exports on the JHipster side. Refer https://github.com/jhipster/generator-jhipster-svelte/issues/1841

@deepu105 , can we reopen?

github-actions[bot] commented 1 year ago

JHipster has completed the sample check .yo-rc.json: Entities JDL: Application: successfully generated Frontend check: skipped Backend check: skipped E2E check: skipped

mshima commented 9 months ago

Changing the package.json exports for generator-jhipster will almost for sure be a breaking change. We support node 18 in v8. Closing.