search

jhipster / generator-jhipster

JHipster is a development platform to quickly generate, develop, & deploy modern web applications & microservice architectures.
https://www.jhipster.tech
Apache License 2.0
21.54k stars 4.02k forks source link

Consul support uses a deprecated token query parameter #22677

Open mraible opened 1 year ago

mraible commented 1 year ago
Overview of the issue

I created a microservices architecture using my Micro Frontends demo script today and noticed there are a lot of deprecation warnings from Consul:

[WARN]  agent.http: This request used the token query parameter which is deprecated and will be removed in Consul 1.17: 
logUrl=/v1/catalog/services?token=<hidden>
Motivation for or Use Case

It'd be nice if there weren't deprecation warnings in log files.

Reproduce the error

Following my demo script and you'll see the warnings after you start the full stack with docker compose up.

JHipster Version(s)

main branch as of June 26, 2023.

deepu105 commented 1 year ago

There is also no OIDC support since its an enterprise feature in Consul

mraible commented 1 year ago

It says the token query parameter is deprecated and will be removed in Consul 1.17. Should we be concerned?

mraible commented 1 year ago

I added a bug bounty to get this fixed.

Survival1sm commented 1 year ago

This appears to be an issue with the unmaintained consul-api library used by spring-cloud-consul for http requests.

Issue on spring-cloud-consul Issue on consul-api Issue for Spring Cloud Consul to migrate away from consul-api: spring-cloud-consul

BrayanMnz commented 2 months ago

Should this be worked on or already done? @mraible

mraible commented 2 months ago

This is still an issue as far as I know.

BrayanMnz commented 2 months ago

Assign this to me, I will take a look at it @mraible

mraible commented 2 months ago

@BrayanMnz Done!