jhipster / generator-jhipster

JHipster is a development platform to quickly generate, develop, & deploy modern web applications & microservice architectures.
https://www.jhipster.tech
Apache License 2.0
21.54k stars 4.02k forks source link

.devcontainer for the JHipster generator repository itself to automatically install supported java and npm version when I want to contribute to JHipster #22762

Closed SandraAhlgrimm closed 1 year ago

SandraAhlgrimm commented 1 year ago

To make contributions to the jHipster generator easier and to welcome more new contributors, having a devcontainer in the generator repo itself makes sense.

"I would also like a .devcontainer for the JHipster generator repository itself to automatically install supported java and npm version when I want to contribute to JHipster"

Originally posted by @CodingSpiderFox in https://github.com/jhipster/generator-jhipster/issues/17612#issuecomment-1616670405

atomfrede commented 1 year ago

Would you like to take the lead here? I guess you have most experience with it, @jdubois what do you say?

jdubois commented 1 year ago

Oh that's great, yes let's do this with @SandraAhlgrimm (to be transparent: I'm Sandra's manager at Microsoft )

atomfrede commented 1 year ago

I know, that's why I pinged you :)

SandraAhlgrimm commented 1 year ago

sure, I am happy to start this @atomfrede

mraible commented 1 year ago

Adding a bug bounty since this seems like a nice feature to have.

jdubois commented 1 year ago

Thanks @mraible but if this is done by @SandraAhlgrimm I’m afraid this might rise a conflict of interest on the Microsoft side

mraible commented 1 year ago

@jdubois It looks like @mshima has started working on it in #22814. I'm not sure how complete it is.

mshima commented 1 year ago

Sorry if I stepped up in front of @SandraAhlgrimm, there are a few more vscode customizations other than devcontainer that needed documentation like https://github.com/jhipster/generator-jhipster/pull/19849#issuecomment-1625738102.

I've started to playing with code-workspace for jhipster-samples folder, looks promising.

mshima commented 1 year ago

Anyone knows if it's possible to execute a script before building the devcontainer? We should create ../jhipster-samples and node_modules_container folders to be mounted.

mshima commented 1 year ago

@DanielFran bounty claimed https://opencollective.com/generator-jhipster/expenses/163438.

DanielFran commented 1 year ago

@mshima approved