Closed SandraAhlgrimm closed 1 year ago
Would you like to take the lead here? I guess you have most experience with it, @jdubois what do you say?
Oh that's great, yes let's do this with @SandraAhlgrimm (to be transparent: I'm Sandra's manager at Microsoft )
I know, that's why I pinged you :)
sure, I am happy to start this @atomfrede
Adding a bug bounty since this seems like a nice feature to have.
Thanks @mraible but if this is done by @SandraAhlgrimm I’m afraid this might rise a conflict of interest on the Microsoft side
@jdubois It looks like @mshima has started working on it in #22814. I'm not sure how complete it is.
Sorry if I stepped up in front of @SandraAhlgrimm, there are a few more vscode customizations other than devcontainer that needed documentation like https://github.com/jhipster/generator-jhipster/pull/19849#issuecomment-1625738102.
generator-hipster
devcontainer is using the same version workflows and generated applications uses for node, npm and java.I've started to playing with code-workspace for jhipster-samples folder, looks promising.
Anyone knows if it's possible to execute a script before building the devcontainer?
We should create ../jhipster-samples
and node_modules_container
folders to be mounted.
@DanielFran bounty claimed https://opencollective.com/generator-jhipster/expenses/163438.
@mshima approved
To make contributions to the jHipster generator easier and to welcome more new contributors, having a devcontainer in the generator repo itself makes sense.
"I would also like a .devcontainer for the JHipster generator repository itself to automatically install supported java and npm version when I want to contribute to JHipster"
Originally posted by @CodingSpiderFox in https://github.com/jhipster/generator-jhipster/issues/17612#issuecomment-1616670405