Zero sonar code smells at ng-default - Githubissues

jhipster / generator-jhipster

JHipster is a development platform to quickly generate, develop, & deploy modern web applications & microservice architectures.

https://www.jhipster.tech

Apache License 2.0

21.47k stars 4.02k forks source link

Zero sonar code smells at ng-default #25231

Open mshima opened 7 months ago

mshima commented 7 months ago

Overview of the feature request

We have 18 missing code smells now. We can make it to zero.

Suggested fixes (originally posted at https://github.com/jhipster/generator-jhipster/issues/25137#issuecomment-1944422182):

QueryService (6): Add a Specification Builder and functional apis at jhipster-framework to simplify the application side.
CacheConfiguration: ignore at sonar.properties or use metamodel for jpa.
LiquibaseConfig: add a JHipsterProperty for async disabling
Commented codes: drop or move to the generator's README.md and add a link to it.

Motivation for or Use Case

Related issues or PR

https://github.com/jhipster/generator-jhipster/issues/25137

[ ] Checking this box is mandatory (this is just to show you read everything)

mshima commented 7 months ago

The remaining code smells (6 for jpa model filtering and 6 for patch support https://github.com/jhipster/generator-jhipster/issues/25153) are harder to fix.

mshima commented 6 months ago

New sonar rules. 231 issues now.

mshima commented 6 months ago

We have 110 issues which 98 are false positives.

qmonmert commented 5 months ago

False positives are fixed. There are just issues like Refactor this method to reduce its Cognitive Complexity...

mshima commented 5 months ago

Code smells fixed in https://github.com/SonarSource/sonar-html/pull/291

mraible commented 6 days ago

Can this be closed?

qmonmert commented 5 days ago

much better than on February