jhipster / generator-jhipster

JHipster is a development platform to quickly generate, develop, & deploy modern web applications & microservice architectures.
https://www.jhipster.tech
Apache License 2.0
21.56k stars 4.02k forks source link

Removing IntelliJ configuration file while using yo jhipster:upgrade #5618

Closed Ckram closed 7 years ago

Ckram commented 7 years ago
Overview of the issue

When using yo jhipster:upgrade for the first time (when no jhipster_upgrade branch exists yet) it deletes the IDE (IntelliJ IDEA) configuration files

Motivation for or Use Case

It should not delete them because they should be ignored.

Reproduce the error

run yo jhipster:upgrade Then IntelliJ does not recognize the project

I think its done in the cleanUp() of the subGenerator.

{ "generator-jhipster": { "jhipsterVersion": "4.3.0", "baseName": "name", "packageName": "com.package.name", "packageFolder": "com/package/name", "serverPort": "8080", "authenticationType": "session", "hibernateCache": "ehcache", "clusteredHttpSession": false, "websocket": false, "databaseType": "sql", "devDatabaseType": "h2Disk", "prodDatabaseType": "postgresql", "searchEngine": false, "messageBroker": false, "serviceDiscoveryType": false, "buildTool": "maven", "enableSocialSignIn": false, "rememberMeKey": "", "clientFramework": "angular1", "useSass": false, "clientPackageManager": "yarn", "applicationType": "monolith", "testFrameworks": [ "gatling", "cucumber", "protractor" ], "jhiPrefix": "jhi", "enableTranslation": true, "nativeLanguage": "fr", "languages": [ "fr", "en" ] } }

Browsers and Operating System

java version "1.8.0_121" Java(TM) SE Runtime Environment (build 1.8.0_121-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.121-b13, mixed mode)

git version 2.10.0

node: v6.10.0

npm: 4.3.0

bower: 1.8.0

gulp: [10:25:16] CLI version 1.2.2 [10:25:16] Local version 3.9.1

yeoman: 1.8.5

yarn: 0.21.3

Skit5 commented 7 years ago

Have you tried to ignore them like explained here ? https://jhipster.github.io/configuring-ide-idea/

Ckram commented 7 years ago

Yes I had to do it again after the upgrade to let idea recognize my files

pascalgrimaud commented 7 years ago

The subgenerator upgrade used git to upgrade by starting on a clean branch, without your idea config So I confirm the issue, but I'm not sure if we can do something about that

If you have something to propose to improve this subgenerator, feel free to do a PR @Ckram

jdubois commented 7 years ago

Closing as the PR is merged