jhipster / generator-jhipster

JHipster is a development platform to quickly generate, develop, & deploy modern web applications & microservice architectures.
https://www.jhipster.tech
Apache License 2.0
21.55k stars 4.02k forks source link

Typo in _Jenkinsfile , non Yarn deployment #6222

Closed jakubstrama closed 7 years ago

jakubstrama commented 7 years ago
Overview of the issue

There is most likely a typo in _/generators/ci-cd/templates/jenkins/_Jenkinsfile Lines: 81-83. A yarn argument is being used instead of npm argument.

Motivation for or Use Case

Brakes the non Yarn Jenkins deployment, frontend-maven-plugin:npm -Dfrontend.yarn.arguments=test resolves to npm install instead of npm test

Reproduce the error

Deploy with Jenkins without Yarn

Related issues
Suggest a Fix

change to:

./mvnw com.github.eirslett:frontend-maven-plugin:npm -Dfrontend.npm.arguments=test

JHipster Version(s)

4.6.2

JHipster configuration

Executing jhipster:info Options:

JHipster Version(s)
leavemyride@0.0.0 /Users/jakubstrama/dev/leavemyride
└── generator-jhipster@4.6.2 
JHipster configuration, a .yo-rc.json file generated in the root folder
.yo-rc.json file
{
  "generator-jhipster": {
    "promptValues": {
      "packageName": "com.leavemyride",
      "nativeLanguage": "en"
    },
    "jhipsterVersion": "4.6.2",
    "baseName": "leavemyride",
    "packageName": "com.leavemyride",
    "packageFolder": "com/leavemyride",
    "serverPort": "8080",
    "authenticationType": "jwt",
    "hibernateCache": "no",
    "clusteredHttpSession": false,
    "websocket": false,
    "databaseType": "sql",
    "devDatabaseType": "postgresql",
    "prodDatabaseType": "postgresql",
    "searchEngine": "elasticsearch",
    "messageBroker": false,
    "serviceDiscoveryType": "eureka",
    "buildTool": "maven",
    "enableSocialSignIn": true,
    "jwtSecretKey": "replaced-by-jhipster-info",
    "clientFramework": "angularX",
    "useSass": true,
    "clientPackageManager": "npm",
    "applicationType": "monolith",
    "testFrameworks": [
      "cucumber",
      "protractor"
    ],
    "jhiPrefix": "jhi",
    "enableTranslation": true,
    "nativeLanguage": "en",
    "languages": [
      "en",
      "de",
      "pl"
    ]
  }
}
JDL for the Entity configuration(s) entityName.json files generated in the .jhipster directory
JDL entity definitions

Environment and Tools

java version "1.8.0_51" Java(TM) SE Runtime Environment (build 1.8.0_51-b16) Java HotSpot(TM) 64-Bit Server VM (build 25.51-b03, mixed mode)

git version 2.8.4 (Apple Git-73)

node: v7.7.1

npm: 4.1.2

yeoman: 2.0.0

Docker version 1.12.1, build 23cf638

Execution complete

yo-rc.txt

Entity configuration(s) entityName.json files generated in the .jhipster directory
Browsers and Operating System
gmarziou commented 7 years ago

Thanks, would you please consider submitting a pull request?

jakubstrama commented 7 years ago

Hi, I do not have the code base checked out at the moment, just went through the github page quickly.

gmarziou commented 7 years ago

There's no emergency