Suffixes when generating a gateway on over a microservice

tstebut commented 6 years ago

Overview of the issue

Generating a gateway over a microservice, entity generator gives suffixes.

=> I had to do some shell commands to rename files, paths and replace text in .ts and .html files, which were named with, or contained, the words "MySuffix" or "my-suffix"

I eve tryed to use the --angular-suffix switch but no results.....

Motivation for or Use Case

I'd really like to fluently generate and upgrade my gateways across distinct sets of microservices.... What happenned with suffixes thoug ?

Reproduce the error

Go to my issue initially created, in the wrong place https://github.com/angular/angular/issues/21212 => actually it was initially because of a 4.13.0 issue which was fixed by 4.13.1 I guesse, YET the suffix issue remains !! => so can be reproduce by following the mentionned issue .

Suggest a Fix

=> take care of the issue

JHipster Version(s)

The latest: 4.13.1

JHipster configuration

See my prototype gitlab with specified branch : https://gitlab.com/tanguy.von.stebut/bank-account-kata/tree/JHIPSTER-MICROSERVICE

[x] Checking this box is mandatory (this is just to show you read everything)

jdubois commented 6 years ago

Please follow the guidelines, I can't work like this, I need your configuration

jdubois commented 6 years ago

This ticket has been closed as the guidelines are not followed.

Tickets must follow our Guidelines, as mentioned in:

our Readme file on the front page of the project,
the "create a new ticket" page and
our Help page

We have also created a template on the "create a new ticket" page to help you follow those guidelines.

If this is indeed a JHipster bug, please open a new issue with proper details or update this issue with all details and request to reopen. Issues opened without proper details will be closed without explanation.

If you have a question please use Stack Overflow, and tag the question with jhipster. This helps the project to keep the issue tracker clean. Also, Stack Overflow will give your question a larger audience:

This will increase your chances to get an answer
Answers will be of higher quality, as there is a voting system
This will also help other users who might have the same issue, as questions are tagged and easily searchable

jdubois commented 6 years ago

Of course I'll re-open if you send your full config, please send it

tstebut commented 6 years ago

OK thanks :+1: :dancing_men:

Configuration:

For Gateway https://gitlab.com/tanguy.von.stebut/bank-account-kata/tree/JHIPSTER-MICROSERVICE/gateway
For Microservice https://gitlab.com/tanguy.von.stebut/bank-account-kata/tree/JHIPSTER-MICROSERVICE/microservice
Fo registry : compiled and ran exactly as is from https://github.com/jhipster/jhipster-registry

jdubois commented 6 years ago

Please put your config in the ticket. I don't have Internet connection right now, I mostly work async in public transportation....

Le 30 déc. 2017 10:22 AM, "Ass7" notifications@github.com a écrit :

OK thanks 👍 👯‍♂️

Configuration:

For Gateway https://gitlab.com/tanguy.von. stebut/bank-account-kata/tree/JHIPSTER-MICROSERVICE/gateway https://gitlab.com/tanguy.von.stebut/bank-account-kata/tree/JHIPSTER-MICROSERVICE/gateway

For Microservice https://gitlab.com/tanguy.von. stebut/bank-account-kata/tree/JHIPSTER-MICROSERVICE/microservice https://gitlab.com/tanguy.von.stebut/bank-account-kata/tree/JHIPSTER-MICROSERVICE/microservice

Fo registry : compiled and ran exactly as is from https://github.com/jhipster/jhipster-registry https://github.com/jhipster/jhipster-registry

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/jhipster/generator-jhipster/issues/6921#issuecomment-354536073, or mute the thread https://github.com/notifications/unsubscribe-auth/AATVo2l9tdWPhVLLhgeKiVeU-_vtdSITks5tFgDBgaJpZM4RPW0q .

tstebut commented 6 years ago

ok, got it

{
  "generator-jhipster": {
    "promptValues": {
      "packageName": "com.bak.gateway",
      "nativeLanguage": "en",
      "microservicePath": "../microservice"
    },
    "jhipsterVersion": "4.13.1",
    "baseName": "bakGw",
    "packageName": "com.bak.gateway",
    "packageFolder": "com/bak/gateway",
    "serverPort": "8080",
    "authenticationType": "jwt",
    "cacheProvider": "hazelcast",
    "enableHibernateCache": true,
    "clusteredHttpSession": "hazelcast",
    "websocket": false,
    "databaseType": "sql",
    "devDatabaseType": "h2Disk",
    "prodDatabaseType": "mysql",
    "searchEngine": false,
    "messageBroker": false,
    "serviceDiscoveryType": "eureka",
    "buildTool": "maven",
    "enableSocialSignIn": false,
    "enableSwaggerCodegen": true,
    "jwtSecretKey": "739fd0267bd9f02fdee6c77b1806cab2f883da53",
    "clientFramework": "angularX",
    "useSass": false,
    "clientPackageManager": "yarn",
    "applicationType": "gateway",
    "testFrameworks": [
      "gatling",
      "cucumber",
      "protractor"
    ],
    "jhiPrefix": "jhi",
    "enableTranslation": true,
    "nativeLanguage": "en",
    "languages": [
      "en",
      "fr"
    ]
  }
}

=> for gateway

tstebut commented 6 years ago

And for microservice:

{
  "generator-jhipster": {
    "promptValues": {
      "packageName": "com.bank.account.kata",
      "nativeLanguage": "en"
    },
    "jhipsterVersion": "4.13.0",
    "baseName": "bak",
    "packageName": "com.bank.account.kata",
    "packageFolder": "com/bank/account/kata",
    "serverPort": "8081",
    "authenticationType": "jwt",
    "hibernateCache": "hazelcast",
    "clusteredHttpSession": false,
    "websocket": false,
    "databaseType": "sql",
    "devDatabaseType": "h2Disk",
    "prodDatabaseType": "mysql",
    "searchEngine": "elasticsearch",
    "messageBroker": false,
    "serviceDiscoveryType": "eureka",
    "buildTool": "maven",
    "enableSocialSignIn": false,
    "enableSwaggerCodegen": true,
    "jwtSecretKey": "0f7db93061643672bd81f0eb20ad382e6f62ba44",
    "enableTranslation": true,
    "applicationType": "microservice",
    "testFrameworks": [
      "gatling",
      "cucumber"
    ],
    "jhiPrefix": "jhi",
    "nativeLanguage": "en",
    "languages": [
      "en",
      "ca",
      "fr",
      "de"
    ],
    "clientPackageManager": "yarn",
    "skipClient": true,
    "skipUserManagement": true
  }
}

All the rest is default and latest, as per previous comments

jdubois commented 6 years ago

And I guess you created some entities using the JDL, with the "Angular Suffix" flag? I'm just reading your first issue again, I'm not sure I understand everything correctly in fact: you used that Angular suffix flag and are not happy with it?

jdubois commented 6 years ago

BTW @deepu105 our default JDL uses the Angular suffix flag by default, and I see a lot of people keeping it, so they have stupid "-with-suffix" stuff everyone. It's an optional flag, it shouldn't be there in the default sample I think - could we remove it?

deepu105 commented 6 years ago

@jdubois we could it was just to show a sample and I wasn't expecting people to use the JDL as it is.

@Ass7 I dont understand your issue at all, this is why we have an issue template and we ask for those details. Please update the issue or open a new one with all the details asked in the template and clearly explain what your issue is and how to reproduce it. I'm not gonna waste time on issues which are incomplete

tstebut commented 6 years ago

Ok...yes I tryed to use the flag setting suffix to somethi g else, yet it did nothing.

Now I have to appologize that even if I googled that earlyer, and had the clue already, I dis not ough to check in the jdl file....feeling like omg this must not be it. But now yet I check and you re obviously right @jdubois ...

https://gitlab.com/tanguy.von.stebut/bank-account-kata/blob/JHIPSTER-MICROSERVICE/microservice/jhipster-jdl.jh

It's in the jdl, rught at the end....so I guess removing it and regenarting it we'll work...and also I'll be able to use the flag in commandline with effect this time? Anyway I feel impatient to test it again...

Thank you..

Hmm also let me say my approach...I've always think that appfuse, petstore, kitchensink...and even more all kinds of scaffolding tools , rails, grails, roo....are made for starting an app, so we can make it adapt to the need faster, by prototyping first and then iterate over and over. So when I came to the jdl studio, I was impressed to adapt the sample and quickly be able to use it, no matter how perfect my definition was, and planning to do it probably a couple of time before doing it good. hehe all I want is playing and have fun you know!

So my suggestion advice would be certainly to remove the angular suffix from it, and secondly...being able to reload the sample....yes it's true...as at some points I was modifying it , I also wanted to get it back and verify again if my syntax was ok, feeling then a bit lost in relationships expression, as usual, haha.

So well, I hope this share of Ux was't a bad gift for this coming new year...blah bla ;)

jdubois commented 6 years ago

Thanks for the feedback!!! Yes let's remove the suffix by default if that's ok with you Deepu

Le 30 déc. 2017 6:22 PM, "Deepu K Sasidharan" notifications@github.com a écrit :

Closed #6921 https://github.com/jhipster/generator-jhipster/issues/6921.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/jhipster/generator-jhipster/issues/6921#event-1405135168, or mute the thread https://github.com/notifications/unsubscribe-auth/AATVo9IhcjtvKDxZKFPTL45IDaAMs_0hks5tFnFBgaJpZM4RPW0q .

jhipster / generator-jhipster