jdubois
commented
6 years ago Great catch @hdurix - then we should never be in auto commit mode, but for that specific "getAll" request we indeed are... Now let me give a few hints here:
- Usually in JHipster we always use transactions (so no problem)
- But for very simple code like a "getAll", if we don't use a service layer, then we go straight to the repository with no transaction. That's because the code is much simpler that way.
- So for your specific use case there is indeed no "@Transactional", and so you are using the default database mode, which uses autocommit (with HikariCP)
There are 3 ways to solve this:
- Mark the repository @Transactional : I don't like it very much, because that gives more work to the service layer (which has to join the transaction, etc). So there's a little performance hit, for nothing much.
- Mark the REST endpoint with @Transactional(readOnly=true) : I don't like having transactions in the view layer. There's one added benefit from the point above: you can mark your transaction as readonly, so you have a performance gain.
- Configure the connection pool to have autocommit = false. In fact, I thought we were already doing that, as the (older) connections pools I used were doing this. But that's not the case with HikariCP!!
And I just came across this great blog: https://vladmihalcea.com/why-you-should-always-use-hibernate-connection-provider_disables_autocommit-for-resource-local-jpa-transactions/
-> @hdurix could you test this last solution? As you can read from the blog, there's also a performance boost to gain here, so that would just be perfect.
hdurix
rajshukla865
Zara-Ra
Overview of the issue
When using PostgreSQL (at least), creating a String field with the annotation
@Lobtriggers a bug when getting the entity from the database. APSQLExceptionis thrown:Large Objects may not be used in auto-commit mode..Example of Java code:
Complete stack trace
Motivation for or Use Case
The entity can not be retrieved for database, so can not be serialized and sent to the frontend.
I noticed this bug while working on the protractor delete tests PR:
Reproduce the error
I noticed this bug with the
ngx-psql-es-noi18nsample, so to reproduce the error, the easiest thing to do may be to use the same sample: generate and run the app, create aPlaceand see the error.All the steps if needed (in
generator-jhipster):Related issues
A similar issue has been created by @agoncal: https://github.com/jhipster/generator-jhipster/issues/5995
@duderoot explained that it should be good now so I'm not sure this is exactly the same issue.
Suggest a Fix
No idea for now. Maybe add
@Type(type = "org.hibernate.type.TextType")for PostgreSQL as suggested in the previous issue.Maybe the title is wrong, it can be changed.
JHipster Version(s)
5.2.1but the issue could be here for a long time as protractor does not currently check for the entity to be correctly loaded.JHipster configuration
JHipster Version(s)
JHipster configuration, a
.yo-rc.jsonfile generated in the root folder.yo-rc.json file
{ "generator-jhipster": { "applicationType": "monolith", "baseName": "travisPsqlEsNoi18n", "packageName": "com.mycompany.myapp", "packageFolder": "com/mycompany/myapp", "authenticationType": "jwt", "cacheProvider": "ehcache", "enableHibernateCache": true, "websocket": false, "databaseType": "sql", "devDatabaseType": "postgresql", "prodDatabaseType": "postgresql", "searchEngine": "elasticsearch", "useSass": true, "buildTool": "maven", "enableTranslation": false, "rememberMeKey": "replaced-by-jhipster-info", "testFrameworks": [ "gatling", "protractor" ], "serverPort": "8080", "jhiPrefix": "jhi", "travis": true, "messageBroker": false, "serviceDiscoveryType": false, "clientPackageManager": "yarn", "clientFramework": "angularX" } }JDL for the Entity configuration(s)
entityName.jsonfiles generated in the.jhipsterdirectoryI've got the error at that step when running
jhipster info:stack error
The passed validation must be valid. Errors: No value events.js:183 throw er; // Unhandled 'error' event ^ Error: ERROR! Error while parsing entities to JDL at Environment.error (/home/hippolyte/workspace/jhipster/generator-jhipster/node_modules/yeoman-environment/lib/environment.js:157:40) at module.exports.error (/home/hippolyte/workspace/jhipster/generator-jhipster/generators/generator-base.js:2048:18) at module.exports.generateJDLFromEntities (/home/hippolyte/workspace/jhipster/generator-jhipster/generators/generator-base-private.js:1002:18) at module.exports.displayEntities (/home/hippolyte/workspace/jhipster/generator-jhipster/generators/info/index.js:57:34) at Object. (/home/hippolyte/workspace/jhipster/generator-jhipster/node_modules/yeoman-generator/lib/index.js:418:27)
at /home/hippolyte/workspace/jhipster/generator-jhipster/node_modules/run-async/index.js:25:25
at new Promise ()
at /home/hippolyte/workspace/jhipster/generator-jhipster/node_modules/run-async/index.js:24:19
at self.env.runLoop.add.completed (/home/hippolyte/workspace/jhipster/generator-jhipster/node_modules/yeoman-generator/lib/index.js:419:13)
at runCallback (timers.js:810:20)
Maybe the JDL for this sample project is wrong and causing this issue?
Browsers and Operating System
I've got this error on my laptop (Ubuntu 17.10) and in Travis protractor tests. Not linked to browser.