search

jhipster / jdl-studio

JDL Studio is an online JHipster Domain Language visual editor
https://start.jhipster.tech/jdl-studio/
Apache License 2.0
405 stars 114 forks source link

Fix Syncing jdl-studio Submodule within jhipster-online #101

Closed SudharakaP closed 3 years ago

SudharakaP commented 3 years ago

This fixes the syncing of jdl-studio within jhipster-online.

Fixes #100

SudharakaP commented 3 years ago

@jdubois @deepu105 : For this to work we need to set a Personal Access Token (PAT). I would suggest setting this on Jhipster Bot so that it will create the PR. This PAT needs to be set in a secret named PAT in this repo.

deepu105 commented 3 years ago

I'll check it tomorrow

SudharakaP commented 3 years ago

I'll check it tomorrow

Thanks. 👍🏼

SudharakaP commented 3 years ago

@deepu105 : This is ready to be merged as I was told by @jdubois that the PAT is all set. 😄

deepu105 commented 3 years ago

Ah damn, I totally forgot to check that today. thanks @jdubois

SudharakaP commented 3 years ago

@deepu105 : I forgot to give write access to jhipster-bot for jhispter-online; which I did just now. Would you be able to restart this workflow please to check if it works properly; https://github.com/jhipster/jdl-studio/runs/999723369?check_suite_focus=true. I don't have write access to this repo for some reason.

deepu105 commented 3 years ago

Restarted

SudharakaP commented 3 years ago

@deepu105 : Thanks a lot Deepu. So it works perfectly; https://github.com/jhipster/jhipster-online/pull/221#issuecomment-675685870. If you have time, can you also add an exclusion to jhipster-bot for CLAassistant. That's the only missing piece. 😄