search

jhipster / jdl-studio

JDL Studio is an online JHipster Domain Language visual editor
https://start.jhipster.tech/jdl-studio/
Apache License 2.0
405 stars 114 forks source link

Share link option is broken #33

Closed deepu105 closed 7 years ago

deepu105 commented 7 years ago

Share link option seems to be broken. @sendilkumarn would you have time to take a look at this?

sendilkumarn commented 7 years ago

@deepu105 what is the issue ?

deepu105 commented 7 years ago

In JDL studio we have an option to share a generated link. The generate part works but the app doesnt load the new content based on link anymore when opened in a new browser

yfain commented 7 years ago

I ran into this issue as well. Created a sample entity diagram with two entities: Category and Beer. Created a shareable link http://bit.ly/2s9BYs2. In its expanded form it clearly shows Category and Beer:
https://jhipster.github.io/jdl-studio/#!#%2Fview%2Fentity%20Category%20%7B%0A%20%20%20name%20String%0A%7D%0A%0Aentity%20Beer%20%7B%0A%20%20%20%20name%20String,%0A%20%20%20%20description%20String,%0A%20%20%20%20price%20Long%0A%7D%0A%0Arelationship%20OneToMany%20%7B%0A%20%20%20Category%20to%20Beer%7Bcategory(name)%7D%20%0A%7D%0A

But if you try to open it in a browser, it shows a different diagram with Job, Department, Employee...

jdubois commented 7 years ago

This button is a little bit buggy anyway, as we are limited by the length of the URL parameters -> how about just removing it? We could do something if we had a backend, of course

yfain commented 7 years ago

IMO, this is not overly useful feature. If it not easy to fix, it should be removed.

gmarziou commented 7 years ago

This would be a very useful feature for github issues where jhipster info could build this link.

gmarziou commented 7 years ago

It seems the url is re-encoded.

First the link is loaded with correct route #/view/entity

https://jhipster.github.io/jdl-studio/#/view/entity%20Region.....

and then it changes to re-encoded #!#%2Fview%2Fentity as

https://jhipster.github.io/jdl-studio/#!#%2Fview%2Fentity%20Region%20

jdubois commented 7 years ago

Guys, don't worry on this for the moment : I will hopefully have a solution after this summer :-) For the moment we should remove it.

hosseinmp76 commented 3 years ago

Guys, don't worry on this for the moment : I will hopefully have a solution after this summer :-) For the moment we should remove it.

is this feature forgotten? I think it's really handy in remote work.