jhipster / jdl-studio

JDL Studio is an online JHipster Domain Language visual editor
https://start.jhipster.tech/jdl-studio/
Apache License 2.0
405 stars 114 forks source link

JDL-Studio no showing model errors #57

Closed carloca68 closed 5 years ago

carloca68 commented 5 years ago

Hi folks,

As I remember JDL-Studio was showing your script errors at the bottom of the screen using a red text message. For some reason it is not happening anymore. It's easy to repeat, just write some wrong jdl and check with the console. Some screenshots for Firefox follows, Thanks for the excellent tool.

jdl-studio-noerror

jdl-studio-console

deepu105 commented 5 years ago

I think I missed to catch the error when updating to JDL3, its here, there is no location anymore. I need to work on it

    function handleError(e) {
      var msg = '',
        top = 0;
      if (e.location) {
        var lineHeight = parseFloat($(editorElement).css('line-height'));
        top = 35 + lineHeight * e.location.start.line;
        msg = e.message + ' -> line: ' + e.location.start.line;
      } else {
        throw e;
      }
      $scope.safeApply(function() {
        app.lineMarkerTop = top;
        app.hasError = true;
        app.errorTooltip = msg;
      });
    }
windbender commented 5 years ago

One possible approach here would be to expose the errors messages in some sort of console like display. I realize this not as graceful as highlight the actual line in questions, but it's quick and dirty.

I found exposing the JS console was quite helpful as I was editing JDL since I could see why things were not working.

deepu105 commented 5 years ago

@jdubois can we please do a release for jhipster-online for this. We need to somehow automate this else its quite annoying that we need to sync all changes here to jhipster-online app

@jhipster/developers any idea?

One idea I have is to rebuild this into jhipster-online so that it becomes part of it

deepu105 commented 5 years ago

@jdubois i have updated jh online with this https://github.com/jhipster/jhipster-online/commit/f8c83c31e6f87b4c0d1274191265bb083bc04f2a