search

jhipster / jdl-studio

JDL Studio is an online JHipster Domain Language visual editor
https://start.jhipster.tech/jdl-studio/
Apache License 2.0
405 stars 114 forks source link

Updated JCore to the latest version #88

Closed MathieuAA closed 4 years ago

MathieuAA commented 4 years ago

I had some issues updating the JCore dep, hope this is it. We should migrate to react or vue...

Fixes #85 Fixes #83 Fixes #80 Fixes #65 Fixes #60

And maybe some other issues

deepu105 commented 4 years ago

Ya migrating to React is something I wanted to do but that will be like a complete rewrite

deepu105 commented 4 years ago

@pascalgrimaud @jdubois this needs to be pulled in for next JH online release

pascalgrimaud commented 4 years ago

yes we need to do this, or open a ticket for that. Otherwise, we'll forget... @vishal423 is currently upgrading the JH Online

deepu105 commented 4 years ago

I'll create a ticket, unless @vishal423 wants to pull it in his PR

MathieuAA commented 4 years ago

@deepu105 Pierre has told me of a fork of this project, done in vuejs. I'm gonna fork this in the lab so we can have a look. @PierreBesson thanks again :)

MathieuAA commented 4 years ago

Edit: I forked the wrong project... Here's the original repo: https://github.com/soxueren/vue-jdlstudio And the fork's fork: https://github.com/hipster-labs/vue-jdlstudio

vishal423 commented 4 years ago

I assume JHipster online update is a 2 step process:

Let me know if more steps are involved.

deepu105 commented 4 years ago

I think you just need to run the update command.

vishal423 commented 4 years ago

without the build (first step), changes made via PR https://github.com/jhipster/jdl-studio/pull/87 were not reflected on the UI. I have created another PR https://github.com/jhipster/jdl-studio/pull/89 that also update the distribution bundles to reflect those changes

deepu105 commented 4 years ago

@MathieuAA that is not a direct fork, coz when I look at commit history it doesn't have anything from our repo, I guess its something built from scratch referring to JDL studio. So if we are gonna use anything from there, its better to first check with @soxueren if he is willing to make PR to our lib with required change or at least add a compatible license to his repo. If he does that we can cherry-pick the stuff and create a PR to update our project so history is maintained

deepu105 commented 4 years ago

That lib doen't seem to work properly, especially the diagram render part :disappointed:

deepu105 commented 4 years ago

@MathieuAA i'll update our lib to React, I'll find some time this weekend

MathieuAA commented 4 years ago

Alright! Thanks Deepu.