Issues with the new deployment syntax

[MathieuAA]

@deepu105, can you confirm those?

• [x] in the JDLObect class, there's no stringifying of a deployment inside a JDL object.
• [x] not sure if JDLDeployment#toString works as intended: this method returns something like

  {
  deploymentType docker-compose,
  appsFolders [tata, titi],
  dockerRepositoryName "test"
  }

  instead of

  deployment {
  deploymentType docker-compose,
  appsFolders [tata, titi],
  dockerRepositoryName "test"
  }

I'll add more if I find anything. If you confirm those, I'll work on that.

[deepu105]

@MathieuAA you are right the stringify is definitely wrong. Good catch

[MathieuAA]

@deepu105 The fixes have been committed. Do you need a release?

[jdubois]

I'll do a release of the generator tomorrow morning, please keep me updated

[MathieuAA]

@jdubois Okay! I'll do a release of that and drop a PR in the generator, just to be sure that nothing's missing.

[MathieuAA]

@deepu105 I'm going to close the issue. If someone finds something, this issue still exists and can be reopened.

[MathieuAA]

@jdubois there's a PR in the generator for this issue.

[deepu105]

Thanks man much appreciated

On Mon, 12 Nov 2018, 9:47 pm Mathieu ABOU-AICHI <notifications@github.com wrote:

@deepu105 https://github.com/deepu105 I'm going to close the issue. If someone finds something, this issue still exists and can be reopened.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jhipster/jhipster-core/issues/285#issuecomment-438018237, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDlF08rKc3H7q42HWBqRJxKnKkwllnWks5uudoxgaJpZM4YY_CN .