Fix javadoc detection - Githubissues

jhipster / jhipster-core

JHipster Domain Language, used by JHipster UML and JDL-Studio to generate entities

Apache License 2.0

345 stars 116 forks source link

Fix javadoc detection #293

Closed murdos closed 5 years ago

murdos commented 5 years ago

Fixes #291

Please make sure the below checklist is followed for Pull Requests.

[x] Travis tests are green
[x] Tests are added where necessary
[x] Documentation is added/updated where necessary
[x] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

murdos commented 5 years ago

This is a naive fix, feel free to correct me if I'm wrong. I've renamed the lexer token, and I think more renaming should be done (e.g. JDLEntity.comment -> JDLEntity.javadoc), but I guess it will break external API.

MathieuAA commented 5 years ago

Thanks I'll review this first thing tomorrow!

MathieuAA commented 5 years ago

I don't understand why you've renamed the token. What was the issue with COMMENT?

edit nevermind, got it.

MathieuAA commented 5 years ago

@murdos This PR is good to be merged, thanks! I'll let you merge it whenever you want. Can you please do a npm run bundle before and commit the change? It updates the parsing system with the latest changes. Thanks :)

murdos commented 5 years ago

@MathieuAA I've also run npm run prepare so diagrams have been updated too