Implemented the single & multi app export

jhipster / jhipster-core

JHipster Domain Language, used by JHipster UML and JDL-Studio to generate entities

Apache License 2.0

346 stars 116 forks source link

Implemented the single & multi app export #343

Closed MathieuAA closed 5 years ago

MathieuAA commented 5 years ago

Please make sure the below checklist is followed for Pull Requests.

[x] Travis tests are green
[X] Tests are added where necessary
[X] Documentation is added/updated where necessary
[X] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

MathieuAA commented 5 years ago

@Shaolans this is my version of the single & multi app + entities export, can you have a look and compare with yours? if you have the time of course

Shaolans commented 5 years ago

The logic behind seems to be similar to me 👍. The major difference is about exporting multi apps, I am exporting on just one jdl as you are exporting a jdl on each apps. I don't know which is the better one, I was thinking that if we have subfoldes containing apps, it sould probably correponds to microservices apps used for an entire project, thus keeping all into one jdl but I might be wrong.

MathieuAA commented 5 years ago

Nop, that's a good point! Your logic is better here.

MathieuAA commented 5 years ago

@Shaolans it's way better, thanks for the review.