jhipster / jhipster-core

JHipster Domain Language, used by JHipster UML and JDL-Studio to generate entities
Apache License 2.0
345 stars 116 forks source link

ALL option handling in the parser makes the syntax check fail #366

Closed Shaolans closed 5 years ago

Shaolans commented 5 years ago
Overview of the issue

Since the all option is handled now as a NAME token. The syntax check is now failing because since this is a NAME token and because of the entityList rule in the parser, it tries to check the name syntax as a entity name. However ENTITY_NAME_PATTERN does not match all making it fail.

Motivation for or Use Case

When the jhipster-core is linked to the generator, the tests fails in the generator due to a test using a jdl containing service all with serviceImpl.

Reproduce the error

Link the jhipster-core (master) on the generator-jhipster (master) and launch the generator tests.

Related issues

https://github.com/jhipster/jhipster-core/commit/19395457011595d9245bcc8952eecc5e86d3f2c5

Suggest a Fix

Either revert the all handling back or add the edge case of all option in the syntax checking but we might need to fix some other problems too.

JHipster Version(s)

Master version

JHipster configuration
Entity configuration(s) entityName.json files generated in the .jhipster directory
Browsers and Operating System
MathieuAA commented 5 years ago

Thanks for reporting it, I'll fix it before the week-end release