New unary option `readOnly` to declare an entity as read-only

jhipster / jhipster-core

JHipster Domain Language, used by JHipster UML and JDL-Studio to generate entities

Apache License 2.0

346 stars 116 forks source link

New unary option `readOnly` to declare an entity as read-only #370

Closed murdos closed 4 years ago

murdos commented 4 years ago

Fixes #318

I used the keywork readOnly, but only at end I realized that it could have been readonly (both are used in #318). Please let me know what you prefer, and I'll update the PR.

Please make sure the below checklist is followed for Pull Requests.

[x] Travis tests are green
[X] Tests are added where necessary
[X] Documentation is added/updated where necessary
[X] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

MathieuAA commented 4 years ago

Thanks @murdos I'll test this out ASAP!

murdos commented 4 years ago

Thanks. I'm going to add the missing test. So do we keep readOnly or readonly?

MathieuAA commented 4 years ago

readOnly is good, let's keep it this way

murdos commented 4 years ago

Ok. Missing test has been added

MathieuAA commented 4 years ago

Thanks :)

MathieuAA commented 4 years ago

Alright, let's merge it. Thanks @murdos!