jhipster / jhipster-core

JHipster Domain Language, used by JHipster UML and JDL-Studio to generate entities
Apache License 2.0
346 stars 116 forks source link

Added NodeJS workflow #371

Closed MathieuAA closed 4 years ago

MathieuAA commented 4 years ago

For GH actions, only on PRs to master for now

Please make sure the below checklist is followed for Pull Requests.

pascalgrimaud commented 4 years ago

@MathieuAA : nice job here. I'd like you have your opinion about GH actions. Do you plan to remove Travis ? Stay with GH actions only ? What about Azure Pipelines ?

MathieuAA commented 4 years ago

@pascalgrimaud Hi! My short-term goal was to try it (check!), and remove the Travis checks but keep Azure pipelines for the time being. What do you think?

pascalgrimaud commented 4 years ago

I'd like you remove Travis for all our organization.

Then, use GH actions for repo where the CI is simple (npm install, build, test). Azure should be use only when there is some generation + configs, so when the CI is complex

Thanks for adding this, it will help me to start understanding GH actions :)

MathieuAA commented 4 years ago

I'll try. Gotta do a major release today for JCore and update the docs before I'll be able to play with actions a bit more.

MathieuAA commented 4 years ago

So I can remove the Azure check here too then?

pascalgrimaud commented 4 years ago

Let's wait a little bit to see how GH actions works. If it works well, then yes, let's remove Travis and Azure.

For Azure, I'll do it, because I need to delete jhipster-core in Azure orga first.

MathieuAA commented 4 years ago

Roger that