Don't generate changelogDate.

jhipster / jhipster-core

JHipster Domain Language, used by JHipster UML and JDL-Studio to generate entities

Apache License 2.0

346 stars 116 forks source link

Closed mshima closed 4 years ago

mshima commented 4 years ago

Let generator-jhipster create changelogDate.

Please make sure the below checklist is followed for Pull Requests.

[ ] Checks are green
[ ] Tests are added where necessary
[ ] Documentation is added/updated where necessary
[ ] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

MathieuAA commented 4 years ago

Why was it closed?

mshima commented 4 years ago

There are 2 approaches. This one that removes changelogDate. The other implements reproducible build.

This patch became kind of breaking (is this safe?) and big. The other seems to be cleaner. Uploading it tomorrow.

When I upload it tomorrow I will reopen this pr so you can decide which pr is better.

MathieuAA commented 4 years ago

Thank you. Tomorrow I'll be quite busy and might not review your work before the night.

mshima commented 4 years ago

See https://github.com/jhipster/jhipster-core/pull/409. Feel free to close this if you prefer that PR.