jhipster / jhipster-core

JHipster Domain Language, used by JHipster UML and JDL-Studio to generate entities
Apache License 2.0
346 stars 116 forks source link

Do not allow underscore in baseName to prevent invalid hostnames #418

Closed josepaiva94 closed 4 years ago

josepaiva94 commented 4 years ago

Please make sure the below checklist is followed for Pull Requests.

Fixes #417 with the suggested fix "Add error message when user tries to generate microservice with an underscore or illegal character according to URI spec in the service name."

However, i would like to use dashes. May I make another PR or is there a good reason against dashes in baseName?

MathieuAA commented 4 years ago

Hello, your fix disallow underscores for every type of app, not just MS. Yes, another PR for dashes if they are allowed.