Add returnMergedEntity option

jhipster / jhipster-core

JHipster Domain Language, used by JHipster UML and JDL-Studio to generate entities

Apache License 2.0

346 stars 116 forks source link

Closed mshima closed 4 years ago

mshima commented 4 years ago

Please make sure the below checklist is followed for Pull Requests.

[ ] Checks are green
[ ] Tests are added where necessary
[ ] Documentation is added/updated where necessary
[ ] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

MathieuAA commented 4 years ago

Can you finish this PR please @mshima?

mshima commented 4 years ago

@MathieuAA sure. I will try later today.

mshima commented 4 years ago

Probably I will split in smaller PRs.

MathieuAA commented 4 years ago

Thanks :) Do as you please!

mshima commented 4 years ago

@MathieuAA first round is ready.

MathieuAA commented 4 years ago

Can we close this one then?

mshima commented 4 years ago

Can we close this one then?

There are 2 more changes.

mshima commented 4 years ago

@MathieuAA this is the last one for now.

mshima commented 4 years ago

I just noticed that the only method that take subFolder (application.name) into account is writeEntities. Am I wrong or should we change that?

MathieuAA commented 4 years ago

I just noticed that the only method that take subFolder (application.name) into account is writeEntities. Am I wrong or should we change that?

@mshima sorry didn't see your comment... Anyway, this is good to go, thanks :)