Skip Hard Stop Error Message When OptionType Does Not Exist

jhipster / jhipster-core

JHipster Domain Language, used by JHipster UML and JDL-Studio to generate entities

Apache License 2.0

345 stars 116 forks source link

Skip Hard Stop Error Message When OptionType Does Not Exist #446

Closed SudharakaP closed 4 years ago

SudharakaP commented 4 years ago

When some option type is missing we do not hard stop. Instead we log that the option type is missing and move on.

Fixes https://github.com/jhipster/generator-jhipster/issues/11532

Please make sure the below checklist is followed for Pull Requests.

[ ] Checks are green
[x] Tests are added where necessary
[x] Documentation is added/updated where necessary
[x] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

MathieuAA commented 4 years ago

Almost done, after the two points it's good to go!

MathieuAA commented 4 years ago

Thank you!

SudharakaP commented 4 years ago

You are welcome and thanks for the review. :smile:

mshima commented 4 years ago

This PR disables the field validation for everything when the spec is not defined. This is not a big deal because lexer fails on import with an unknown field, but with blueprint support (unknown field for lexer). This should be fixed.

https://github.com/jhipster/jhipster-core/pull/449 adds an option ignoreUnknownOptions that should be added to generator-jhipster.