jhipster / jhipster-core

JHipster Domain Language, used by JHipster UML and JDL-Studio to generate entities
Apache License 2.0
345 stars 116 forks source link

Add support to export unknown configurations. #453

Closed mshima closed 4 years ago

mshima commented 4 years ago

Please make sure the below checklist is followed for Pull Requests.

murdos commented 4 years ago

Just nitpicking on the wording: wouldn't external, additional or extra options be better than unknown options?

mshima commented 4 years ago

Just nitpicking on the wording: wouldn't external, additional or extra options be better than unknown options?

I'm not sure, this is internal only for now. External/additional/extra should be import/export support but only validation is tested for now.

This is part of https://github.com/jhipster/jhipster-core/pull/449. It became big, so I will split into smaller features to be easier to review.

MathieuAA commented 4 years ago

So we're talking about configuration options, right? What if, and it's just a question, validation is only done unless there's at least one blueprint in the JDLApplication? The code is getting "heavier", that's why I raise the other possibility.

mshima commented 4 years ago

What if, and it's just a question, validation is only done unless there's at least one blueprint in the JDLApplication?

Are you taking about this PR or blueprints support?

MathieuAA commented 4 years ago

Everything. I'm wondering if we took the right decision or we could have made everything simpler.

mshima commented 4 years ago

@MathieuAA you should take a look now. I think generic_jdl_application_configuration_option can replace *_jdl_application_configuration_option.