search

jhipster / jhipster-core

JHipster Domain Language, used by JHipster UML and JDL-Studio to generate entities
Apache License 2.0
345 stars 116 forks source link

Change default database to postgresql #467

Closed agaspardcilia closed 4 years ago

agaspardcilia commented 4 years ago

@MathieuAA Is there anything more to do to change that?

To be merge once https://github.com/jhipster/generator-jhipster/issues/11736 is complete.

Please make sure the below checklist is followed for Pull Requests.

MathieuAA commented 4 years ago

@agaspardcilia only this file has to be updated. And quite a lot of tests too ;)

mshima commented 4 years ago

@MathieuAA I think once jhipster-core is merged into generator-jhipster, jdl should not set default values at all, should let generator-jhipster use it defaults.

MathieuAA commented 4 years ago

@mshima 100% agreed, the future JDL/core/whatever module will have to consume defaults from a source :) Be it the generator or jhipster base

mshima commented 4 years ago

@agaspardcilia just be aware this repository is about to be discontinued. @MathieuAA are you merging the merge PR with this repository?

MathieuAA commented 4 years ago

I'll handle the code changes from this repo to the "super jhipster" thing (I don't have a name for it yet, working on it). As long as the CI here passes, it should be merged. However, as this PR is related to v7, I won't merge it.

mshima commented 4 years ago

@MathieuAA are you planning to create a new repository for generator-jhipster?

MathieuAA commented 4 years ago

@mshima no, there's a PR in the generator for this: https://github.com/jhipster/generator-jhipster/pull/11694. It's very basic, but it's intended: refactorings, design decisions, etc. should be made after this. The PR doesn't even change the generator's behavior at all.

MathieuAA commented 4 years ago

Here's the discussion in the mailing list

mshima commented 4 years ago

Yep I remember that, I was confused about your "super jhipster"

MathieuAA commented 4 years ago

Ah! that's the name of this thing. I know, it's a poor name but it was either that or calling it "the merged version" :(

agaspardcilia commented 4 years ago

@MathieuAA Yeah, I feel like this database change will be more about testing than making actual changes. 😅 @mshima Alright, I just hope I'll be done with this one before this repos is discontinued then.

MathieuAA commented 4 years ago

@agaspardcilia Hello there! I'm tidying up the merge PR (https://github.com/jhipster/generator-jhipster/pull/11694). As this PR is quite small (tests excluded), I suggest you do another one in the generator once the merge is... merged. Or I can do the update for you. Whatever suits you best.

pascalgrimaud commented 4 years ago

Closing this as JCore has been merged into generator-jhipster