search

jhipster / jhipster-kotlin

Kotlin based JHipster
https://khipster.dev
Apache License 2.0
455 stars 95 forks source link

Feature parity with parent Java project #85

Closed pvliss closed 5 years ago

pvliss commented 5 years ago

Overview of the issue

This is a list of generators and their sub-packages provided by the parent JHipster project in Java and need to be migrated to Kotlin:

1st level: Generators: 2nd level: Packages

~- [ ] aws-containers~ Removing this based on our discussion.

NOTES:

  1. Tests are not mentioned in the list but should be done alongside the main code
  2. The order is alphabetical

Motivation for or Use Case

Achieve feature parity with parent JHipster Java project

JHipster Version(s)

6.x

[x] Checking this box is mandatory (this is just to show you read everything)

pvliss commented 5 years ago

So I have started the porting and decided to first start with the domain package as the entity generator is now done and seemed logical to have all domain objects in Kotlin. I have completed the port but the problem is that several tests fail with NullPointerExceptions as when Java classes use the Kotlin constructors the default arguments are ignored. This is especially true for the User class as it is being used in many places. Hence, this will have to wait for now.

I will instead continue with the configuration and other packages and work towards the domain packages to avoid such problems.

pvliss commented 5 years ago

@sendilkumarn Just a status update. I have also finished with the gateway and repository packages as well but will wait for the merge of #86 first as it changed server/files.js heavily and I would like to avoid conflicts/difficult merges for the other PRs.

amatosg commented 5 years ago

@pvliss If it's ok with you, I would like to work on the service layer as of #89

pvliss commented 5 years ago

Hello @amatosg. You are more than welcome to help and help is really needed. I have actually already converted the service package. See the commits at #88. I am now pushing commits over there as they also target JHipster 6.x. Also I am just finishing the cucumber tests.

I will update what has already been done in the title. Then just pick what you are comfortable with and let us know.

pvliss commented 5 years ago

I have also done domain but have not pushed the commit yet.

amatosg commented 5 years ago

so, what's missing? I see web but I'm not sure what layer is that.

pvliss commented 5 years ago

For anyone interested to help out I will continue with the migration of the repository package. Just mentioning to avoid duplicate work

pvliss commented 5 years ago

LOL. Just posted as well

pvliss commented 5 years ago

Well, yes the remaining are web, security and client as well some code in aws-containers subgenerator

pvliss commented 5 years ago

They are all under the server sub-generator.

The java code can found here: https://github.com/jhipster/generator-jhipster/tree/master/generators/server/templates/src/main/java/package

The Kotlin code should be placed under here: https://github.com/jhipster/jhipster-kotlin/tree/master/generators/server/templates/src/main/kotlin/package

And any related tests to according packages

pvliss commented 5 years ago

@amatosg I have finished with the repository package as well and thinking of moving on to either the web or security package. Have you decided if and which one you will pick up as I am going to start tommorow? Thanks

amatosg commented 5 years ago

I will give client a try tonight 👍

pvliss commented 5 years ago

Cool. I will continue with web then. Let me know if you need any help and thanks for helping out

pvliss commented 5 years ago

Hello @amatosg. Did you have any time to deal with the client package? Can I be of any help?

amatosg commented 5 years ago

wow, a week already? I'm sorry, but I haven't. I changed to a new project and I've been busy. Did you started that already? otherwise I can do it during the week

pvliss commented 5 years ago

I have not started it but if you do not have time I would like to do it in order to complete this. Let me know if that's ok with you. Thanks

amatosg commented 5 years ago

go ahead, I could take the whole week to finish it at this pace :(

pvliss commented 5 years ago

Thanks a lot. Don't worry there will be plenty of things to contribute to. This is just the beginning