search

jhipster / jhipster-lite

JHipster Lite ⚡ is a development platform to generate, develop & deploy modern web applications & microservices architecture, step by step - using Hexagonal Architecture :gem:
https://www.jhipster.tech/jhipster-lite/
Apache License 2.0
433 stars 196 forks source link

fix: OutOfMemory when try to indent pom.xml without default size #10142

Closed cwichoski closed 2 weeks ago

cwichoski commented 2 weeks ago

If you add many modules and change the indentation size to 4, when newer dependencies are added to pom.xml the current indentation algorithm causes a loop that increase memory exponentially by each dependency, to avoid this we changed to use a XML formatter.

fix #10129

CLAassistant commented 2 weeks ago

CLA assistant check
All committers have signed the CLA.

murdos commented 2 weeks ago

@cwichoski : thanks for reporting the issue, and for trying to fix it! I've worked to improve the behavior of maven-model-helper, the library that we use to serialize pom.xml, so we can avoid rewriting afterwards the pom.xml: https://github.com/fabric8io/maven-model-helper/pull/151 Once the new version is released, things should be fixed with #10143