search

jhipster / jhipster-lite

JHipster Lite ⚡ is a development platform to generate, develop & deploy modern web applications & microservices architecture, step by step - using Hexagonal Architecture :gem:
https://www.jhipster.tech/jhipster-lite/
Apache License 2.0
433 stars 197 forks source link

safely remove libs version reference #10191

Closed renanfranca closed 2 days ago

renanfranca commented 3 days ago

Fix #10060 (see the TO-DO at issue description)

renanfranca commented 2 days ago

@murdos : I generated a sampleapp with gradle using this pull request implementation and it removed the unused versions (mockito, assertjand junit-jupiter)

renanfranca commented 2 days ago

Awesome, thanks! :)

Thanks 😊

renanfranca commented 2 days ago

@murdos : Is it a generic error? https://github.com/jhipster/jhipster-lite/actions/runs/9783882769/job/27014572353#step:21:1 Screenshot_20240703_180007_GitHub.jpg

murdos commented 1 day ago

@murdos : Is it a generic error? https://github.com/jhipster/jhipster-lite/actions/runs/9783882769/job/27014572353#step:21:1 Screenshot_20240703_180007_GitHub.jpg

@renanfranca : Sorry, I've no idea :man_shrugging:

renanfranca commented 1 day ago

I will let it go for now and keep watching it. I tried to rerun all jobs and got a Sonar not initialized error, but when I ran it on localhost, it worked fine. https://github.com/jhipster/jhipster-lite/actions/runs/9783882769/job/27041337459

renanfranca commented 1 day ago

@pascalgrimaud: Bounty Claimed https://opencollective.com/generator-jhipster/expenses/210043. Thanks 😀✌

pascalgrimaud commented 1 day ago

@renanfranca : approved