jhipster / jhipster-lite

JHipster Lite ⚡ is a development platform to generate, develop & deploy modern web applications & microservices architecture, step by step - using Hexagonal Architecture :gem:
https://lite.jhipster.tech
Apache License 2.0
453 stars 209 forks source link

Disable virtual threads by default on generated Spring app #10474

Closed murdos closed 3 weeks ago

murdos commented 1 month ago

There are some edge cases where the usage of java 21 virtual threads is causing issues, so it's better to turn it off, as done by Spring Boot.

Harsh4902 commented 3 weeks ago

@murdos Can I work on this issue?

murdos commented 3 weeks ago

@Harsh4902 : sure! :)

Harsh4902 commented 3 weeks ago

@murdos I hope this change will work, please review it once.

dmurat commented 5 days ago

Can you please shed some light on those issues with virtual threads? Is this something like what is described in the link below, or have you found something else? Tnx. https://stackoverflow.com/questions/78790376/spring-boot-application-gets-stuck-when-virtual-threads-are-used-on-java-21

murdos commented 5 days ago

Here are a few examples:

It doesn't mean virtual threads should not be used, just that this is should be a thoughtful decision since the ecosystem is not yet mature. That's why it's wiser to disable it by default :)