search

jhipster / jhipster-lite

JHipster Lite ⚡ is a development platform to generate, develop & deploy modern web applications & microservices architecture, step by step - using Hexagonal Architecture :gem:
https://lite.jhipster.tech
Apache License 2.0
467 stars 215 forks source link

Remove the svelte module #10910

Open murdos opened 2 months ago

murdos commented 2 months ago

This module has been unmaintained for months, and is already disabled.

We should remove the code since it still add some maintenance burden, and the outdated src/main/resources/generator/dependencies/svelte/package.json contains dependencies with security issues.

pascalgrimaud commented 2 months ago

Little bit sad as it was a good opportunity to have a good architecture with a modular approach

But I understand and respect @vishal423 as he prefers maintaining https://github.com/jhipster/generator-jhipster-svelte

So yes, let's remove it

vishal423 commented 2 months ago

What exactly do we require for svelte maintenance?

murdos commented 2 months ago

@vishal423 : e.g. updating the code to follow generator best/new practices: https://github.com/jhipster/jhipster-lite/commits/8b97ff3836cf8669e6e74d32a04daa04c4846419/src/main/java/tech/jhipster/lite/generator/client/svelte/core/domain/SvelteModuleFactory.java

It's also the only client module that has not moved to Eslint 9, Prettier 3, and does not use recent versions of vite and vitest, ...

vishal423 commented 2 months ago

Do you mean files under src/main/java/tech/jhipster/lite/generator/client/svelte/core?

murdos commented 2 months ago

@vishal423 : Sorry, I misunderstood the situation, I thought that you were the original author of the svelte module in jhipster-lite, and thus that you were familiar with the code 😅

I think there are some technical debt around generated tooling (prettier, eslint, maybe vite and vitest), and the migration from svelte 3 to 4. Once this is done, the maintenance would be very low I guess because the generated content is very minimal, mainly handle breaking svelte changes.

Would you agree to help doing the svelte specific parts? If so, I could handle the tooling upgrade. WDYT?

vishal423 commented 2 months ago

Since I never contributed to this project before, I may need some time to setup local env and try out the code-gen. Further, frontend is a hobby work for me and lately got little time to contribute. I can't commit anything at this moment.

pascalgrimaud commented 2 months ago

Prerequisites are Java 21, Node LTS and git It's similar to what generates classic generator-jhipster, so it's easy to setup

So take your time, no worry

@murdos : so let's wait a little bit, before thinking about removing this module

vishal423 commented 2 months ago

how to view svelte option in UI to generate code?

murdos commented 2 months ago

@vishal423 : it's currently hidden, you can re-enable it by removing this configuration parameter: https://github.com/jhipster/jhipster-lite/blob/0178987c685aa4238b54af2216eac52ba8a7110b/src/main/resources/config/application.yml#L70

vishal423 commented 2 months ago

thanks. I am able to generate. Few questions: