jhipster / jhipster-lite

JHipster Lite ⚡ is a development platform to generate, develop & deploy modern web applications & microservices architecture, step by step - using Hexagonal Architecture :gem:
https://lite.jhipster.tech
Apache License 2.0
468 stars 215 forks source link

Fix: Update apache/kafka-native Docker tag to v3.9.0 #11323

Closed qmonmert closed 1 week ago

qmonmert commented 1 week ago

Fix #11313

@pascalgrimaud @murdos I opend an issue https://github.com/testcontainers/testcontainers-java/issues/9506 on tescontainers. I use temporary fix proposed on the ticket.

murdos commented 1 week ago

Thanks for raising the issue on testcontainers side.

I'd rather wait for the fix/official support from testcontainers. I don't think we're in a hurry to make the upgrade, but that's just my opinion.

qmonmert commented 1 week ago

@murdos ok

@pascalgrimaud merge or wait? 🙂

pascalgrimaud commented 1 week ago

In fact, I'm not sure it's an issue. Maybe the proposed fix is what we should do, as our generated kafka.yml already have this property:

image

qmonmert commented 1 week ago

@pascalgrimaud I believe that kafkaContainer = new KafkaContainer(DockerImageName.parse("apache/kafka-native:3.9.0")).withNetwork(null); not used kafka.yml to start, so updating this file won't change behavior

pascalgrimaud commented 1 week ago

Yes I know, I wanted to say your suggestion would be consistent with the generated kafka.yml file

qmonmert commented 1 week ago

@pascalgrimaud I try to find consistency between two files based on https://github.com/apache/kafka/blob/9db5ed00a8369d5c696e836661230110ea2ea44d/docker/examples/docker-compose-files/single-node/plaintext/docker-compose.yml#L31 but without success

pascalgrimaud commented 1 week ago

I'm merging this, so the upgrade to the v3.9.0 Docker image can be done, until there is a v3.9.1 with an eventual fix

qmonmert commented 1 week ago

👍