search

jhipster / jhipster-lite

JHipster Lite ⚡ is a development platform to generate, develop & deploy modern web applications & microservices architecture, step by step - using Hexagonal Architecture :gem:
https://lite.jhipster.tech
Apache License 2.0
467 stars 215 forks source link

Add Spring Boot LangChain4j sample #11335

Closed anunnakian closed 2 weeks ago

anunnakian commented 2 weeks ago

Add a sample of using LangChain4J with Spring Boot Web

anunnakian commented 2 weeks ago

@pascalgrimaud here is the PR to add a LangChain4j sample ;)

pascalgrimaud commented 2 weeks ago

In the last PR, I forgot to tell you to add a new config to test in the CI, the new modules langchain4j

Could you add a new one here?

Then, add it to the CI:

pascalgrimaud commented 2 weeks ago

By adding to the CI the generated app, it will show you that the generated app with langchain4j is not totally covered: missing tests for ChatResource

pascalgrimaud commented 2 weeks ago

Cc @renanfranca : what happened when we added a new config in script.sh and it doesn't exist in main branch? The checksum with md5 should be ignored, right?

renanfranca commented 2 weeks ago

Cc @renanfranca : what happened when we added a new config in script.sh and it doesn't exist in main branch? The checksum with md5 should be ignored, right?

The pipeline will break because the MD5 checksum is generated after it tries and fails to create the non-existent app in generate.sh in the main branch.

In my previous experience creating a new app in generate.sh and adding it to the github-actions.yml matrix, I had to add the new app in generate.sh and merge it with the main branch. Only after that could I add the new app to the matrix.

I saw your comment here only today. Yes, i think it should ignored non existing apps.

renanfranca commented 2 weeks ago

I saw your comment here only today. Yes, i think it should ignored non existing apps.

But will it run on main branch CI? I think so...

renanfranca commented 2 weeks ago

I saw your comment here only today. Yes, i think it should ignored non existing apps.

But will it run on main branch CI? I think so...

Screenshot_20241110_231019_Vivaldi

I am having second thoughts about the importance of checking out the complete project from the main branch if it's only using the test-ci folder to run commands with the downloaded main jar file, which is not updated and generates an error when adding a new app in generate.sh and including the app in the GitHub Actions matrix in a pull request.

@pascalgrimaud and @murdos : What do you think about checking out from the current branch as well at step name: 'Setup: checkout project from main branch' and keeping everything else unchanged?

pascalgrimaud commented 2 weeks ago

I created the ticket here https://github.com/jhipster/jhipster-lite/issues/11341