search

jhipster / jhipster-lite

JHipster Lite ⚡ is a development platform to generate, develop & deploy modern web applications & microservices architecture, step by step - using Hexagonal Architecture :gem:
https://lite.jhipster.tech
Apache License 2.0
463 stars 212 forks source link

Switch to non parallel stream in rest pagination mapping #6803

Closed DamnClin closed 1 year ago

DamnClin commented 1 year ago

Update needs to be done here: https://github.com/jhipster/jhipster-lite/blob/main/src/main/resources/generator/server/pagination/rest/main/RestAppPage.java.mustache

murdos commented 1 year ago

It should be removed from the jpa pagination mapping too: https://github.com/jhipster/jhipster-lite/blob/197c063cb9d4127dcd121131431ec894596f03d1/src/main/resources/generator/server/pagination/jpa/AppPages.java.mustache#L34

murdos commented 1 year ago

@DamnClin : you self assigned this issue, so I'm assuming you already have a fix or intend to do it. Otherwise let me know, I can take care of the fix.

DamnClin commented 1 year ago

@DamnClin : you self assigned this issue, so I'm assuming you already have a fix or intend to do it. Otherwise let me know, I can take care of the fix.

Sorry, self assign was a mistake, I was thinking to leave it as a good first issue since we need more of them :D

murdos commented 1 year ago

Sorry, self assign was a mistake, I was thinking to leave it as a good first issue since we need more of them :D Ok, then I'm leaving this issue for new contributors :)

jayasekharreddy-telluri commented 1 year ago

can i take these issue?

DamnClin commented 1 year ago

can i take these issue?

All yours

jayasekharreddy-telluri commented 1 year ago

can i get some information like what needs to be done?

DamnClin commented 1 year ago

Explained in issue and comments :⁠-⁠)

Update needs to be done here: https://github.com/jhipster/jhipster-lite/blob/main/src/main/resources/generator/server/pagination/rest/main/RestAppPage.java.mustache

jayasekharreddy-telluri commented 1 year ago

can i know how to run the code VS code.. and how can check my changes are working or not i am in confusion need some help..

DamnClin commented 1 year ago

https://github.com/jhipster/jhipster-lite/blob/main/CONTRIBUTING.md

jayasekharreddy-telluri commented 1 year ago

ok i made the changes but i dont know how to check means i would like to check in frontend how my change is impacting please guide me..

DamnClin commented 1 year ago

ok i made the changes but i dont know how to check means i would like to check in frontend how my change is impacting please guide me..

What do you want to check in the frontend? This is tested automatically, you don't need manual checks

jayasekharreddy-telluri commented 1 year ago

I have to know right what's happening after switching stream to non parallel stream whether we are getting the pagination results are correct or not? how can i check above thing?

DamnClin commented 1 year ago

Yes, push your code to the repository, an application will be generated and test will be run on this application. You can see tests in the module you updated. There is no need to do manual checks when developing, checks must be automated