jhipster / jhipster-registry

JHipster Registry, based on Spring Cloud Netflix Eureka and Spring Cloud Config
Apache License 2.0
698 stars 657 forks source link

Add Google Cloud Run Deploy Button #398

Open SudharakaP opened 4 years ago

SudharakaP commented 4 years ago
Overview of the issue

I tried to do this on https://github.com/jhipster/jhipster-registry/pull/395 but ran into some problems both with the Google Cloud Run Button side which we've discussed at https://github.com/GoogleCloudPlatform/cloud-run-button/issues/112 and on the JHipster Registry side which @jkutner is woking on at https://github.com/jhipster/jhipster-registry-buildpack/issues/3. After these issues are solved I'll re-add this button and test it out. 😄

Related issues:

Motivation for or Use Case

Quickly deploy the registry to cloud run just as we do on Heroku.

Related issues

https://github.com/jhipster/jhipster-registry/issues/397

mraible commented 4 years ago

If you run into issues, you might ask @jamesward for help.

jkutner commented 4 years ago

I've fixed and merged https://github.com/jhipster/jhipster-registry-buildpack/issues/3 so the app.json in this repo should be testable now.

SudharakaP commented 4 years ago

Just for the information, I think the buildpacks field still needs to be supported as per https://github.com/GoogleCloudPlatform/cloud-run-button/issues/3 in order to test this. Otherwise we get,

Welcome to Cloud Shell! Type "help" to get started.
To set your Cloud Platform project in this session use “gcloud config set project [PROJECT_ID]”
sudharakapalamakumbura@cloudshell:~$ cloudshell_open --repo_url "https://github.com/SudharakaP/jhipster-registry.git" --page "shell" --git_branch "add-cloud-run-button"
[ ✓ ] Cloned git repository https://github.com/SudharakaP/jhipster-registry.git.
Error: error attempting to read the app.json from the cloned repository: failed to parse app.json file: failed to parse app.json: json: unknown field "buildpacks"
sudharakapalamakumbura@cloudshell:~$
jamesward commented 4 years ago

I'll investigate how we can support this.

SudharakaP commented 4 years ago

@jamesward : Thanks a bunch. Feel free to let know if there's anything we can do on our end.