Update spring-boot version to 2.2 and spring-cloud to Hoxton

jhipster / jhipster-registry

JHipster Registry, based on Spring Cloud Netflix Eureka and Spring Cloud Config

Apache License 2.0

698 stars 657 forks source link

Update spring-boot version to 2.2 and spring-cloud to Hoxton #408

Closed juliensadaoui closed 4 years ago

juliensadaoui commented 4 years ago

Please make sure the below checklist is followed for Pull Requests.
[ ] Travis tests are green
[ ] Tests are added where necessary
[ ] Documentation is added/updated where necessary
[ ] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

juliensadaoui commented 4 years ago

thanks a lot for update all dependencies @DanielFran !

DanielFran commented 4 years ago

@juliensadaoui Just missing update on maven-compiler plugin due to Java 11 and should be OK!

juliensadaoui commented 4 years ago

Spring boot 2.2.3 is release important which contains fixes for CVE-2020-5398 and CVE-2020-5397.

juliensadaoui commented 4 years ago

@DanielFran The Java 11 build failed, i don't understand. The VM settings is correct

Unpacking adoptopenjdk-11-hotspot (11.0.6+10-2) ...
Setting up adoptopenjdk-11-hotspot (11.0.6+10-2) ...
openjdk version "11.0.6" 2020-01-14
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.6+10)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.6+10, mixed mode)

DanielFran commented 4 years ago

@juliensadaoui I know, I talk with @pascalgrimaud about this issue.

I found those 3 PR related with Java 11 migration:

The last 2 are related with this issue.

juliensadaoui commented 4 years ago

The Azure pipeline is green. The pipeline step starts a bash shell with --noprofile and --norc flags. The shell uses the default jvm inside the virtual machine. Below the output of mvn -version command:

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /home/vsts/.m2/wrapper/dists/apache-maven-3.6.3-bin/1iopthnavndlasol9gbrbg6bf2/apache-maven-3.6.3
Java version: 1.8.0_232, vendor: Azul Systems, Inc., runtime: /usr/lib/jvm/zulu-8-azure-amd64/jre
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "5.0.0-1027-azure", arch: "amd64", family: "unix"

I configured the jvm version (AdoptOpenJDK 11) in the step which builds/tests the server-side

sudo update-java-alternatives -s adoptopenjdk-11-hotspot-amd64
JAVA_HOME=$(readlink -f /usr/bin/java | sed "s:bin/java::")
./mvnw -version
./mvnw -ntp verify

DanielFran commented 4 years ago

@juliensadaoui Not sure maven.compiler.release is needed to be declared...

juliensadaoui commented 4 years ago

@DanielFran The release configuration is a new compiler parameter to replace the source and target version parameters (since Java 9)

juliensadaoui commented 4 years ago

You are right ! The java.version property is used for the maven-compiler-plugin configuration. The maven.compiler.target and maven.compiler.release properties are never used in the pom.xml

DanielFran commented 4 years ago

@pascalgrimaud @juliensadaoui Just waiting for the new version of jhipster bom and this is ready to be merged.

DanielFran commented 4 years ago

@pascalgrimaud Re-launched the tests!

juliensadaoui commented 4 years ago

I have tested the registry with microservices connected to it, and using jwt, oauth2 and uaa profiles. It works fine.