jhipster / jhipster-uml

UML support for JHipster
http://jhipster.github.io/jhipster_uml.html
Apache License 2.0
260 stars 99 forks source link

Consider dropping support of Visual Paradigm XMI files #152

Closed MathieuAA closed 8 years ago

MathieuAA commented 8 years ago

I'm submitting this issue to @jhipster/developers, @jhipster/uml, and to everyone willing to participate in this debate: should we drop VP?

The pros

  1. One less editor to support, study and follow;
  2. The XMI is HUGE (~0.15% of useful XML to read) and work to speed up the reading of such files is tedious (and shouldn't be done by us);
  3. VP is very expensive ($, €, etc.);
  4. Working with this editor is really painful for us.

    The cons

  5. One less editor :(;
  6. Almsot a breaking change, and it could be delayed...

    Alternative to the cons

  7. Having the VP parser as a module

    Precisions

Please, feel free to give your input here (I will be updating this post). The indicated milestone is not set for good, it's just a practical non-moving target.

gmarziou commented 8 years ago

Just a naive question: does the modules system for jhipster apply to jhipster-uml?

MathieuAA commented 8 years ago

Not sure if it's the right place to post this, but yes and no. Yes because @CarlKlagba did the work for it, it's a custom implementation that allows others to require('jhipster-uml') and use some classes. No because, as far as I understand JHispter's module system, JHipster UML is not a generator and JHipster's module sub-generator is kind of a proxy used by modules to access JHipster's generators. We only provide endpoints to some parts of JHipster UML without pulling to many dependencies.

gmarziou commented 8 years ago

Thanks, I asked this because I thought that maybe it could have been a way to drop VP from core while letting some volunteers (if any) take over it as a module

MathieuAA commented 8 years ago

I think I understand your question now =) We didn't have in mind having some plug-ins for JHipster UML. But yes, this is a good idea.

Update: after reading the code from the fortune cookie, I can say without any doubt that implementing a VP parser module would be very easy.

deepu105 commented 8 years ago

I thought the editor aupport was already some kind of plugin stuff On 29 Feb 2016 02:31, "Mathieu ABOU-AICHI" notifications@github.com wrote:

I think I understand your question now =) We didn't have in mind having some plug-ins for JHipster UML. But yes, this is a good idea.

— Reply to this email directly or view it on GitHub https://github.com/jhipster/jhipster-uml/issues/152#issuecomment-189918155 .

MathieuAA commented 8 years ago

Yes and no. As you can see, all 4 XMI parsers are integrated inside JHipster UML's source packages. If someone, as Gaël said, would take over the VP parser, then he/she would have to create another project, create the class and use JHipster UML to do the rest (scheduling, and generating the JSON). It is, however, easy to remove the parser as the code is not bound with any parser implementation. So yes, in that regard, you can consider each parser implementation as a plug-in.

dalves96 commented 8 years ago

Hi. I had some success using Visual Paradigm as main exporter uml/xmi file. Here is a way to continuing using Visual Paradigm with some help of Modelio.

So I will explain the procedure:

First I've made the structure on Visual Paradigm similar to the Jhipster-Uml complete example, with various types like Blob and ZonedDateTime. Next I've exported to xmi/uml like the explanation on the site and imported on Modelio, then I only needed to make same small changes like: -The Role on the non Navigable side couldn't have anything written (except on OneToOne or ManyToMany relations). image

Then jhipster-uml path/to/the/xmi/file should work without a problem.

I've noticed a duplicaton bug after the file is loaded to Jhipster on the used parameters for the Blob type. I don't know if that already does on the files original created on Modelio or not?

Pros: Can still use Visual Paradigm. Less work to do. Almost have no bugs(I think) Cons: I have to use 2 parsers, and have 2 exports; And have a more time expended changing the relations.

I hope this helps to continuing using Visual Paradigm. If there is some interest on this way to use Visual Paradigm I can make a public project with commits to see the changes maded to the code to eseally see the changes.
Does this count as a viable way to use VisualParadigm with Modelio?

MathieuAA commented 8 years ago

Well, the main problem I have with VP is that it's not free, and I can't test or fix issues as easily as with the other parsers. Your solution, if I understand it correctly (correct me if I'm wrong), would be to use VP from the very start and that's what I find difficult. VP requires a license and I don't want to pay. As suggested here, one could just create a module for VP and support it by using the various classes JHipster UML makes available (and will make very shortly).

MathieuAA commented 8 years ago

All the work will be done here. I'll close this as soon as I get it done.