search

jhipster / jhipster-vuejs

A Vue.js blueprint for JHipster. It will use Vue.js as the frontend library!
https://www.jhipster.tech
Apache License 2.0
301 stars 179 forks source link

Fix delete confirmation dialog i18n(#501) #503

Closed weblogichub closed 4 years ago

weblogichub commented 4 years ago

Fixes #501

atomfrede commented 4 years ago

thanks @weblogichub Don't worry about the failed build it is because we have not yet updated to latest main generator version.

pascalgrimaud commented 4 years ago

close / reopen for restarting the build

hdurix commented 4 years ago

I just tested your change, the translation is now correctly handled but e2e tests are failing: the Delete button doesn't open the delete modal in the first time, you need to click twice on the button. I've found the fix: by adding:

    if (<any>this.$refs.removeEntity) {
      (<any>this.$refs.removeEntity).show();
    }

at the end of the method prepareRemove as @atomfrede did for user management.

You can give it a try on this branch.

pascalgrimaud commented 4 years ago

Closing this PR in favor of https://github.com/jhipster/jhipster-vuejs/pull/542