Add Promise Reject in case of an error

jhipster / jhipster-vuejs

A Vue.js blueprint for JHipster. It will use Vue.js as the frontend library!

https://www.jhipster.tech

Apache License 2.0

301 stars 179 forks source link

Add Promise Reject in case of an error #543

Closed pascalgrimaud closed 4 years ago

pascalgrimaud commented 4 years ago

Cherry pick from https://github.com/jhipster/jhipster-vuejs/pull/467

rebase against master

Fix https://github.com/jhipster/jhipster-vuejs/issues/466

Please make sure the below checklist is followed for Pull Requests.
[ ] Azure tests are green
[ ] Tests are added where necessary
[ ] Documentation is added/updated where necessary
[ ] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

pascalgrimaud commented 4 years ago

The build failed with this stackstrace:

Jest: "global" coverage threshold for functions (70%) not met: 66.5%

Test Suites: 112 passed, 112 total
Tests:       425 passed, 425 total
Snapshots:   0 total
Time:        61.722s
Ran all test suites.

It means we need to add some tests to cover this new code

pascalgrimaud commented 4 years ago

Resolved in the last commit. I'm merging this