search

jhipster / jhipster-vuejs

A Vue.js blueprint for JHipster. It will use Vue.js as the frontend library!
https://www.jhipster.tech
Apache License 2.0
301 stars 179 forks source link

Feature/infinite scroll #556

Closed skmaingi closed 4 years ago

skmaingi commented 4 years ago

fix https://github.com/jhipster/jhipster-vuejs/issues/537

skmaingi commented 4 years ago

@pascalgrimaud There are other errors thrown outside the scope of work I was working on like

   found in

      ---> <OperationUpdate>
             <Root>
    console.error node_modules/vue/dist/vue.runtime.common.dev.js:621
      [Vue warn]: <select multiple v-model="operation.labels"> expects an Array value for its binding, but got Undefined

      found in

      ---> <OperationUpdate>
             <Root>

(node:8388) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'replace' of undefined
(node:8388) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 56)
(node:8388) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'replace' of undefined
(node:8388) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 57)
pascalgrimaud commented 4 years ago

I think it's just a warning. The last build failed because of % of coverage

skmaingi commented 4 years ago

@pascalgrimaud can I go ahead and close pull request?

pascalgrimaud commented 4 years ago

@skmaingi : I don't understand, why do you want to close this pull request ?

skmaingi commented 4 years ago

@pascalgrimaud Apologies. You can review the work.

pascalgrimaud commented 4 years ago

One build still failed with this log: Jest: "global" coverage threshold for branches (60%) not met: 59.3% I think you need to add test for data-utils.service.ts

skmaingi commented 4 years ago

@pascalgrimaud There is this error

Download latest chrome binary
12s
Get:25 http://azure.archive.ubuntu.com/ubuntu bionic-updates/universe Translation-en [326 kB]
Run sudo apt update

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

Hit:1 http://azure.archive.ubuntu.com/ubuntu bionic InRelease
Get:2 http://azure.archive.ubuntu.com/ubuntu bionic-updates InRelease [88.7 kB]
Get:3 http://azure.archive.ubuntu.com/ubuntu bionic-backports InRelease [74.6 kB]
Get:5 https://download.mono-project.com/repo/ubuntu stable-bionic InRelease [5143 B]
Ign:6 http://dl.google.com/linux/chrome/deb stable InRelease
Hit:7 https://dl.yarnpkg.com/debian stable InRelease
Hit:8 https://cli-assets.heroku.com/apt ./ InRelease
Get:9 https://packages.microsoft.com/repos/azure-cli bionic InRelease [3965 B]
Get:10 http://packages.cloud.google.com/apt cloud-sdk InRelease [6337 B]
Get:11 https://packages.microsoft.com/repos/microsoft-ubuntu-bionic-prod bionic InRelease [4003 B]
Hit:4 https://packages.cloud.google.com/apt kubernetes-xenial InRelease
Get:12 https://packages.microsoft.com/ubuntu/16.04/prod xenial InRelease [4003 B]
Get:13 http://dl.google.com/linux/chrome/deb stable Release [943 B]
Get:14 http://dl.google.com/linux/chrome/deb stable Release.gpg [819 B]
Hit:15 http://ppa.launchpad.net/ansible/ansible/ubuntu bionic InRelease
Get:16 http://security.ubuntu.com/ubuntu bionic-security InRelease [88.7 kB]
Hit:17 http://ppa.launchpad.net/apt-fast/stable/ubuntu bionic InRelease
Get:18 http://azure.archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages [868 kB]
Hit:20 http://ppa.launchpad.net/git-core/ppa/ubuntu bionic InRelease
Get:21 http://azure.archive.ubuntu.com/ubuntu bionic-updates/main Translation-en [301 kB]
Get:22 http://azure.archive.ubuntu.com/ubuntu bionic-updates/restricted amd64 Packages [32.7 kB]
Get:23 http://azure.archive.ubuntu.com/ubuntu bionic-updates/restricted Translation-en [8440 B]
Get:24 http://azure.archive.ubuntu.com/ubuntu bionic-updates/universe amd64 Packages [1052 kB]
Get:25 http://azure.archive.ubuntu.com/ubuntu bionic-updates/universe Translation-en [326 kB]
pascalgrimaud commented 4 years ago

I can restart in the case of this error. But right now, I still see failures from frontend tests

skmaingi commented 4 years ago

@pascalgrimaud : All checks have passed

pascalgrimaud commented 4 years ago

good ! finally :) I'll review it asap, thanks for your hard work

skmaingi commented 4 years ago

@pascalgrimaud Thank you for the opportunity to work on the feature.

skmaingi commented 4 years ago

@pascalgrimaud I have made the requested changes.

skmaingi commented 4 years ago

@pascalgrimaud : I claimed the bounty at OpenCollective expense Thank you

pascalgrimaud commented 4 years ago

@skmaingi : approuved :)